Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161966607 reset password #13

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Conversation

actlikewill
Copy link
Contributor

@actlikewill actlikewill commented Dec 5, 2018

What does this pull request do?

Add the password reset feature

Description of the tasks to be completed?

  • add functionality to enable users to reset their password
  • send an email with a link to reset the password
  • add tests to test the above functionalities.

How should this be manually tested?

  • Clone the repo git clone https://github.com/andela/ah-technocrats.git

  • cd ah-technocrats

  • Checkout out to this branch git checkout ft-password-reset-161966607

  • Make virtual environment python3 -m venv venv

  • Activate the virtual environment source venv/bin/activate

  • Install all the dependencies from the requirements file pip install -r requirements.txt

  • Make migrations python manage.py makemigrations

  • Apply the migrations python manage.py migrate

  • Run the server python manage.py runserver

  • Using Postman, register a user with a valid email address.

screen1

  • To make a password reset make a post request with your email address to the route
    POST / api/users/forgot_password/

screen2

  • You should recieve a link in your inbox if the email you provided is valid.

screen3

  • Following the link should lead you to a Django Rest Framework Change Password Page where you can change your password. The new password should have at least 8 characters, one number, one letter, and one special character.

screen4

  • You can also copy the link to Postman and make a PUT request with the new password.

Any background context you want to provide?

  • The user requires a method to reset a password in case they forget it.
  • The reset feature needs to be secure and only accessible to the user via their email.

What are the relevant Pivotal Tracker Stories

#161966607

Checklist:

  • My code follows the style guidelines of this project
  • At least 2 people have reviewed my PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My PR has one commit.

 - send email with link to reset password
 - allow user to reset password

[Finishes #161966607]
Copy link
Contributor

@verenceLola verenceLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @actlikewill. I like the flow of the PR instructions. Keep it up.

@Mnickii
Copy link

Mnickii commented Dec 5, 2018

Very well documented steps, great PR description

Copy link

@Mnickii Mnickii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@Mnickii Mnickii merged commit e310dde into develop Dec 5, 2018
@verenceLola verenceLola temporarily deployed to ah-technocrats December 5, 2018 16:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants