Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161966610 CRUD for Article #21

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Conversation

SnyderMbishai
Copy link
Contributor

@SnyderMbishai SnyderMbishai commented Dec 11, 2018

What does this pull request do?

This PR implements the CRUD methods for articles.

Description of the tasks to be completed?

  • create article
    POST /api/articles/

  • get article
    GET /api/articles/<slug>

  • get articles
    GET /api/articles/

  • update articles
    PUT /api/articles/<slug>

  • delete articles
    DELETE /api/articles/<slug>

  • test the above functionalities

How should this be manually tested?

   $ git clone https://github.com/andela/ah-technocrats.git
   $ cd ah-technocrats
   $ git checkout ft-create-articles-161966610
   $ python3 -m venv venv
   $ source venv/bin/activate
   $ pip install -r requirements.txt
   $ python manage.py makemigrations
   $ python manage.py migrate
   $ python manage.py runserver

testing:

   $ python manage.py test

Screenshots:

Posting an article
image

Get all articles
image

Get a specic article using it's slug
image

Update an article
image

Delete article
image

Testsing
image
image

What are the relevant Pivotal Tracker Stories

#161966610

Checklist:

  • My code follows the style guidelines of this project
  • At least 2 people have reviewed my PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My PR has one commit.

authors/apps/articles/views.py Show resolved Hide resolved
authors/apps/articles/views.py Outdated Show resolved Hide resolved
authors/apps/articles/views.py Show resolved Hide resolved
authors/apps/articles/views.py Outdated Show resolved Hide resolved
feat(articles): Format code

feat(articles): add permissions

feat(testing): test articles

feat(testing): refactor tests

feat(articles): add slug to url

feat(testing): test articles

chore(articles): edit return message

chore(articles): refactor code

- add docstrings
- add assert statements

[Delivers #161966610]

chore(articles): format code
@codeclimate
Copy link

codeclimate bot commented Dec 11, 2018

Code Climate has analyzed commit 0f7791e and detected 0 issues on this pull request.

View more on Code Climate.

@SnyderMbishai SnyderMbishai removed the WIP Work In Progress label Dec 11, 2018
@salma-nyagaka
Copy link
Contributor

The PR has been documented well and the endpoints seem to be working fine

Copy link
Contributor

@TeamoreA TeamoreA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link
Contributor

@verenceLola verenceLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@verenceLola verenceLola added the Merge This First Merge this PR last label Dec 12, 2018
Copy link

@Mnickii Mnickii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mnickii Mnickii merged commit 8e2bd92 into develop Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge This First Merge this PR last
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants