-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#161966610 CRUD for Article #21
Conversation
45980b8
to
59a9cf6
Compare
59a9cf6
to
636571d
Compare
636571d
to
92e46f9
Compare
feat(articles): Format code feat(articles): add permissions feat(testing): test articles feat(testing): refactor tests feat(articles): add slug to url feat(testing): test articles chore(articles): edit return message chore(articles): refactor code - add docstrings - add assert statements [Delivers #161966610] chore(articles): format code
92e46f9
to
0f7791e
Compare
Code Climate has analyzed commit 0f7791e and detected 0 issues on this pull request. View more on Code Climate. |
The PR has been documented well and the endpoints seem to be working fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this pull request do?
This PR implements the CRUD methods for articles.
Description of the tasks to be completed?
create article
POST /api/articles/
get article
GET /api/articles/<slug>
get articles
GET /api/articles/
update articles
PUT /api/articles/<slug>
delete articles
DELETE /api/articles/<slug>
test the above functionalities
How should this be manually tested?
testing:
Screenshots:
Posting an article
![image](https://user-images.githubusercontent.com/26184510/49810152-a23f7680-fd71-11e8-98cf-8e731ff47de8.png)
Get all articles
![image](https://user-images.githubusercontent.com/26184510/49810199-bedbae80-fd71-11e8-8f0a-e8ad76552bff.png)
Get a specic article using it's slug
![image](https://user-images.githubusercontent.com/26184510/49810259-e7fc3f00-fd71-11e8-9364-a08c07106f6b.png)
Update an article
![image](https://user-images.githubusercontent.com/26184510/49810959-4f66be80-fd73-11e8-9ed0-15b0a11cfe66.png)
Delete article
![image](https://user-images.githubusercontent.com/26184510/49811089-9359c380-fd73-11e8-84d6-e5c4fe25d6d8.png)
Testsing
![image](https://user-images.githubusercontent.com/26184510/49811402-432f3100-fd74-11e8-8610-029238554b20.png)
![image](https://user-images.githubusercontent.com/26184510/49811410-475b4e80-fd74-11e8-9d4e-cd45be1a0c05.png)
What are the relevant Pivotal Tracker Stories
#161966610
Checklist: