Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162632841 fix permissions in the registration class #26

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

salma-nyagaka
Copy link
Contributor

@salma-nyagaka salma-nyagaka commented Dec 13, 2018

What does this pull request do?

This PR fixes the bug of adding permissions in the registration class

Description of the tasks to be completed?

  • Register a user
    POST /api/users/
  • Get all authors
    GET /api/users/

How should this be manually tested?

   $ git clone https://github.com/andela/ah-technocrats.git
   $ cd ah-technocrats
   $ git checkout fix-permissions-162632841
   $ python3 -m venv venv
   $ source venv/bin/activate
   $ pip install -r requirements.txt
   $ python manage.py makemigrations
   $ python manage.py migrate
   $ python manage.py runserver

testing:

   $ python manage.py test

Screenshots:

Getting all authors

screen shot 2018-12-13 at 12 33 05

Registering a user

screen shot 2018-12-13 at 12 33 11

What are the relevant Pivotal Tracker Stories

#162632841

Checklist:

  • My code follows the style guidelines of this project
  • At least 2 people have reviewed my PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My PR has one commit.

Copy link
Contributor

@verenceLola verenceLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

…tion class

- add a method in the permission file for authenticating the GET request and adding AllowAny permission to the POST request

[Deilvers #162632841]
@codeclimate
Copy link

codeclimate bot commented Dec 13, 2018

Code Climate has analyzed commit 4fa7275 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

@Mnickii Mnickii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mnickii Mnickii merged commit d007f82 into develop Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants