Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161966623: add reading time estimation #39

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

TeamoreA
Copy link
Contributor

What does this pull request do?

This PR estimates the reading time of an article.

Description of the tasks to be completed?

  • Gets the article and estimates the reading time using average human reading speed in words per minute.

How should this be manually tested?

   $ git clone https://github.com/andela/ah-technocrats.git
   $ cd ah-technocrats
   $ git checkout ft-read-time-161966623
   $ virtualenv -p python3 env
   $ source env/bin/activate
   $ pip install -r requirements.txt
   $ python manage.py makemigrations
   $ python manage.py migrate
   $ python manage.py runserver

testing:
$ ./manage.py test

Screenshots:

Show the time taken to read an article
image

What are the relevant Pivotal Tracker Stories

#161966623

Checklist:

  • My code follows the style guidelines of this project
  • At least 2 people have reviewed my PR
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • My PR has one commit.

Copy link
Contributor

@salma-nyagaka salma-nyagaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reading time is okey

actlikewill
actlikewill previously approved these changes Dec 21, 2018
Copy link
Contributor

@actlikewill actlikewill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and simple implementation. It looks okay.

Copy link
Contributor

@SnyderMbishai SnyderMbishai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please solve the current conflicts.

- estimate reading time for an article

[Delivers #161966618]
@codeclimate
Copy link

codeclimate bot commented Dec 21, 2018

Code Climate has analyzed commit 96c1269 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@verenceLola verenceLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@verenceLola verenceLola merged commit bf2b43d into develop Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants