Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163432887 Fix Saving Of An Article #47

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Conversation

salma-nyagaka
Copy link
Contributor

What does this pull request do?

This PR fixes the bug in the backend, an article was not being saved once updated.

Description of the tasks to be completed?

  • Save an article once updated.

How should this be manually tested?

   $ git clone https://github.com/andela/ah-technocrats.git
   $ cd ah-technocrats
   $ git checkout fix-update-article-163432887
   $ python3 -m venv venv
   $ source venv/bin/activate
   $ pip install -r requirements.txt
   $ python manage.py makemigrations
   $ python manage.py migrate
   $ python manage.py runserver

Screenshots:

Creation of an article

screenshot 2019-01-23 at 23 19 26

Article being updated

screenshot 2019-01-23 at 23 20 43

Updated article

screenshot 2019-01-23 at 23 21 13

What are the relevant Pivotal Tracker Stories

#163432887

Checklist:

  • My code follows the style guidelines of this project
  • At least 2 people have reviewed my PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My PR has one commit.

- save the article to the databse once it has been updated

[Delivers #163432887]
@codeclimate
Copy link

codeclimate bot commented Jan 24, 2019

Code Climate has analyzed commit d8e3229 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@verenceLola verenceLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Copy link
Contributor

@actlikewill actlikewill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix.

Copy link

@dotNesh dotNesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotNesh dotNesh merged commit 341bd1a into develop Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants