Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163644503 Fix Adding Parent Id for Replies To Comments #49

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

actlikewill
Copy link
Contributor

@actlikewill actlikewill commented Feb 1, 2019

What does this pull request do?

This PR fixes the adds a field for the Parent Id for the replies to comments that come from the backend.

Description of the tasks to be completed?

  • Adding the Parent Id to the replies body

How should this be manually tested?

   $ git clone https://github.com/andela/ah-technocrats.git
   $ cd ah-technocrats
   $ git checkout fix-reply-payload-163644503
   $ python3 -m venv venv
   $ source venv/bin/activate
   $ pip install -r requirements.txt
   $ python manage.py makemigrations
   $ python manage.py migrate
   $ python manage.py runserver

After getting Comments Replies from the endpoint,
the payload now includes the Parent ID.

screen shot 2019-02-01 at 09 21 25

What are the relevant Pivotal Tracker Stories

#163644503

Checklist:

  • My code follows the style guidelines of this project
  • At least 2 people have reviewed my PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My PR has one commit.

 - adds the id of the parent comment to the reply array to allow identificaiton

[Finishes : #163644503]
@codeclimate
Copy link

codeclimate bot commented Feb 1, 2019

Code Climate has analyzed commit eae5566 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

@dotNesh dotNesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotNesh dotNesh merged commit c199e6d into develop Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants