Merge 5e2e99e into dbeebb1

andela · May 7, 2019 · 5b0e2af · 5b0e2af
2 parents dbeebb1 + 5e2e99e
commit 5b0e2af
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 22 deletions.
diff --git a/authors/apps/profiles/serializers.py b/authors/apps/profiles/serializers.py
@@ -39,12 +39,3 @@ class FollowingSerializer(serializers.ModelSerializer):
     class Meta:
         model = Followers
         fields = ('profile', 'followed')
-
-
-class UserListSerializer(serializers.ModelSerializer):
-    """
-    Serializer class for getting user profile
-    """
-    class Meta:
-        model = Profile
-        fields = '__all__'
diff --git a/authors/apps/profiles/tests/test_profiles.py b/authors/apps/profiles/tests/test_profiles.py
@@ -72,16 +72,6 @@ def test_successfully_listing_profiles(self):
         """
         Test listing of user profiles 
         """
-        self.is_authenticated("adam@gmail.com", "@Us3r.com")
         response = self.list_profiles()
         self.assertEqual(response.status_code, status.HTTP_200_OK)
         self.assertIsInstance(response.data.get("profiles")[0], dict)
-
-    def test_listing_profiles_with_unauthorised_user(self):
-        """
-        Test listing of user profiles with unauthorised user
-        """
-        response = self.list_profiles()
-        self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
-        self.assertEqual(response.data.get("detail"),
-                         "Authentication credentials were not provided.")
diff --git a/authors/apps/profiles/views.py b/authors/apps/profiles/views.py
@@ -7,7 +7,7 @@
 from authors.apps.authentication.models import User
 from django.shortcuts import get_object_or_404
 
-from .serializers import UserProfileSerializer, UpdateUserProfileSerializer, FollowingSerializer, UserListSerializer
+from .serializers import UserProfileSerializer, UpdateUserProfileSerializer, FollowingSerializer
 from .models import Profile, Followers
 from .renderers import FollowersJSONRenderer
 
@@ -202,11 +202,10 @@ class UserListView(GenericAPIView):
     """
     A class for getting all user profiles
     """
-    permission_classes = [permissions.IsAuthenticated]
 
     def get(self, request):
         queryset = Profile.objects.all()
-        serializer = UserListSerializer(queryset, many=True)
+        serializer = UserProfileSerializer(queryset, many=True)
         return Response({
             'profiles': serializer.data
         }, status=status.HTTP_200_OK)