Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#165305765 Implement user notifications #45

Merged
merged 1 commit into from
May 10, 2019
Merged

#165305765 Implement user notifications #45

merged 1 commit into from
May 10, 2019

Conversation

IssaIan
Copy link
Contributor

@IssaIan IssaIan commented May 8, 2019 •
edited
Loading

What does this PR do?

  • Implement user notifications

What are the tasks to be completed?

  • Implement email and in app notifications

How can this be manually tested?

Local Development Setup

Refer to the project Readme.md for this.
Test with postman

  1. Signing up two users and verify
  2. Follow one user:
POST  http://127.0.0.1:8000/api/profiles/<*username*>/follow/
  1. Create an article using the followed user:
POST http://127.0.0.1:8000/api/articles/
  1. Create a comment with the followed user:
POST http://127.0.0.1:8000/api/articles/<*slug*>/comments/
  1. Fetch the following-user notifications using:
GET http://127.0.0.1:8000/api/notifications/

Screenshots
image

What are the relevant pivotal tracker stories?

[#165305765(https://www.pivotaltracker.com/n/projects/2326460/stories/165305765)

@IssaIan IssaIan force-pushed the ft-notifications-165305765 branch 10 times, most recently from 272c858 to 4fb0e59 Compare May 9, 2019 21:03
@IssaIan IssaIan added the reviews required PR requires reviews before merging label May 9, 2019
@IssaIan IssaIan force-pushed the ft-notifications-165305765 branch 5 times, most recently from 15c612d to d669ac8 Compare May 9, 2019 22:20
@IssaIan IssaIan force-pushed the ft-notifications-165305765 branch 7 times, most recently from 16506be to e321bed Compare May 10, 2019 10:05
ft(notifications): Implement user notifications
5ff2233 
- Implement notification upon creation of articles
- Implement subscription and unsubscription of notifications
- Implement notification upon commenting of a favourited article

[finishes #165305765]
@IssaIan IssaIan force-pushed the ft-notifications-165305765 branch from e321bed to 5ff2233 Compare May 10, 2019 10:14
@oluwagbenga-joloko oluwagbenga-joloko merged commit 9563d0a into develop May 10, 2019
Ogutu-Brian pushed a commit that referenced this pull request May 14, 2019
Merge pull request #45 from andela/ft-notifications-165305765
436704b 
#165305765 Implement user notifications
Ogutu-Brian pushed a commit that referenced this pull request May 14, 2019
Merge pull request #45 from andela/ft-notifications-165305765
adc0f4f 
#165305765 Implement user notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ogutu-Brian Ogutu-Brian Awaiting requested review from Ogutu-Brian

@Amoswachira Amoswachira Awaiting requested review from Amoswachira

Assignees
No one assigned
Labels
reviews required PR requires reviews before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IssaIan @oluwagbenga-joloko