Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166886432 Fix notifications response and email notification url #83

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

matthenge
Copy link
Contributor

What does this PR do?

  • Fix notifications response and email notification URL.

What are the tasks to be completed?

  • Add article slug to the notification response body
  • Fix the view URL in the email notification sent

How can this be manually tested?

a. After cloning the repo:-

$ git checkout  bg-fix-notifications-response
$ python manage.py runserver

Get request

GET http://127.0.0.1:8000/api/notifications/

What are the relevant pivotal tracker stories?

#166886432

…tification url

  - Add article slug in the notification response
  - Fix redirect url when viewing notification in the emails

[starts #166886432]
@matthenge matthenge force-pushed the bg-fix-notifications-response branch from c88c4a2 to 569ed7e Compare June 24, 2019 20:10
@charisschomba charisschomba merged commit 1ee1573 into develop Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants