-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#165305221 Users should be able to Signup #11
Conversation
ec35c52
to
a865965
Compare
a865965
to
be2ed59
Compare
be2ed59
to
06c60f1
Compare
06c60f1
to
0f3e440
Compare
0f3e440
to
59a77f2
Compare
59a77f2
to
36859ed
Compare
36859ed
to
da5dc1e
Compare
da5dc1e
to
8af6749
Compare
8af6749
to
b66c56b
Compare
b66c56b
to
2122f38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice implementation @Elisha-Misoi . However, I feel like you should disable the signup button until all frontend validations are done. Thanks.
2122f38
to
badd7df
Compare
badd7df
to
411cb1b
Compare
@jkamz this won't be a good implementation in a Sign Up form as opposed to Sign In form because the user must be informed as to why the button is disabled. The input fields are quite a lot as compared to the Sign Up form hence it's more efficient to show validation messages such as 'password character length' once the user has clicked the submit button. |
411cb1b
to
9f4fac7
Compare
9f4fac7
to
92429b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work implementing sign up
-add sign up component -add activation component -add tests [Finishes #165305221]
92429b2
to
1c47b90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on implementing user signup. Great work on styling the Navigation bar
What does this PR do?
Users should be able to Signup and or Register using Sign up forms on the signup route.
Description of the task to be completed?
How should you manually test this?
Clone the repository
Switch to testing branch
Switch to the ah-the-jedi-frontend directory
Install project dependencies
Running the application
Screenshots
###Screenshots
What are the relevant PT stories?
#165305221