Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165305221 Users should be able to Signup #11

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

ElishaMisoi
Copy link
Contributor

@ElishaMisoi ElishaMisoi commented May 31, 2019

What does this PR do?

Users should be able to Signup and or Register using Sign up forms on the signup route.

Description of the task to be completed?

  • Ensure an email is sent to a user once they sign up in order to activate their account
  • Register user
  • Activate user account

How should you manually test this?

  • Clone the repository

      $ git clone https://github.com/andela/ah-the-jedi-frontend.git
    
  • Switch to testing branch

     $ git checkout ft-signup-register-165305221
    
  • Switch to the ah-the-jedi-frontend directory

     $ cd ah-the-jedi-frontend/
    
  • Install project dependencies

     $ npm install
    

Running the application

  $ npm start
  • Signup a user

Screenshots

Screenshot 2019-05-31 at 10 55 55

  • Go to the registered email inbox and click verification link

Screenshot 2019-05-31 at 10 56 46

  • Account Activated
    ###Screenshots

Screenshot 2019-05-31 at 11 20 50

What are the relevant PT stories?

#165305221

@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from ec35c52 to a865965 Compare June 3, 2019 07:24
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 3, 2019 07:24 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from a865965 to be2ed59 Compare June 3, 2019 07:29
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 3, 2019 07:29 Inactive
@AnguleMathias AnguleMathias added the WIP PR work in progress label Jun 3, 2019
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from be2ed59 to 06c60f1 Compare June 3, 2019 21:57
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 3, 2019 21:57 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from 06c60f1 to 0f3e440 Compare June 3, 2019 22:14
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 3, 2019 22:14 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from 0f3e440 to 59a77f2 Compare June 3, 2019 22:16
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 3, 2019 22:16 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from 59a77f2 to 36859ed Compare June 4, 2019 00:04
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 4, 2019 00:04 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from 36859ed to da5dc1e Compare June 4, 2019 00:09
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 4, 2019 00:09 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from da5dc1e to 8af6749 Compare June 4, 2019 01:03
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 4, 2019 01:03 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from 8af6749 to b66c56b Compare June 4, 2019 06:37
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 4, 2019 06:38 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from b66c56b to 2122f38 Compare June 4, 2019 06:49
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 4, 2019 06:50 Inactive
@ElishaMisoi ElishaMisoi added Peer Review Waiting for PR Review and removed WIP PR work in progress labels Jun 4, 2019
Copy link
Contributor

@jkamz jkamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice implementation @Elisha-Misoi . However, I feel like you should disable the signup button until all frontend validations are done. Thanks.

@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from 2122f38 to badd7df Compare June 4, 2019 10:12
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 4, 2019 10:12 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from badd7df to 411cb1b Compare June 4, 2019 10:15
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 4, 2019 10:15 Inactive
@ElishaMisoi
Copy link
Contributor Author

ElishaMisoi commented Jun 4, 2019

Very nice implementation @Elisha-Misoi . However, I feel like you should disable the signup button until all frontend validations are done. Thanks.

@jkamz this won't be a good implementation in a Sign Up form as opposed to Sign In form because the user must be informed as to why the button is disabled. The input fields are quite a lot as compared to the Sign Up form hence it's more efficient to show validation messages such as 'password character length' once the user has clicked the submit button.

@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from 411cb1b to 9f4fac7 Compare June 4, 2019 10:40
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 4, 2019 10:40 Inactive
@ElishaMisoi ElishaMisoi force-pushed the ft-signup-register-165305221 branch from 9f4fac7 to 92429b2 Compare June 4, 2019 11:21
@ElishaMisoi ElishaMisoi temporarily deployed to ah-the-jedi-frontend-sta-pr-11 June 4, 2019 11:21 Inactive
Copy link
Contributor

@katherine95 katherine95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work implementing sign up

-add sign up component
-add activation component
-add tests

[Finishes #165305221]
Copy link
Contributor

@Benkimeric Benkimeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on implementing user signup. Great work on styling the Navigation bar

@AnguleMathias AnguleMathias added Approved and removed Peer Review Waiting for PR Review labels Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants