-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#162949233 Article highlighting with comments #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8bb794
to
ca48bd4
Compare
ad7043b
to
0ff1d84
Compare
0ff1d84
to
51aacdd
Compare
be65ec9
to
21d9481
Compare
21d9481
to
a1d75a3
Compare
MbugwaSami
previously requested changes
Feb 4, 2019
a1d75a3
to
e9163eb
Compare
MbugwaSami
previously approved these changes
Feb 4, 2019
e9163eb
to
689ba1d
Compare
Allan690
reviewed
Feb 5, 2019
Allan690
reviewed
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly make the changes requested
689ba1d
to
2796944
Compare
nesh-dev
previously approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work handles the slug issue as well.
Allan690
reviewed
Feb 5, 2019
Allan690
reviewed
Feb 5, 2019
kwanj-k
previously approved these changes
Feb 5, 2019
2796944
to
20d978e
Compare
20d978e
to
864cdd5
Compare
-highlight article -comment on highlighted article -crud for the comment on highlited part of article [Starts #162949233]
864cdd5
to
05eedd6
Compare
kwanj-k
approved these changes
Feb 6, 2019
nesh-dev
approved these changes
Feb 6, 2019
nesh-dev
pushed a commit
that referenced
this pull request
Feb 8, 2019
…9233 #162949233 Article highlighting with comments [Delivers #162949233]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements highlighting of articles and allows commenting on the highlighted section
Description of Task to be completed?
-Highlight article
-Comment on the highlighted article
-crud for the comment on the highlighted part of the article
How should this be manually tested?
Clone the repo:
git clone https://github.com/andela/ah-the-unsullied.git
Cd into the cloned repo
Git checkout to branch
ft-highlight-comment-article-162949233
Set up a virtual environment and install requirements:
Set up a .env file on the same level as the venv file and add the following:
Then run:
Fire up postman and test the following endpoints:
<slug>
/highlight<slug>
/highlight<slug>
/highlight/<int:id>
<slug>
/highlight/<int:id>
<slug>
/highlight/<int:id>
use the following payload format for sharing an article via email:
Any background context you want to provide?
None
What are the relevant pivotal tracker stories?
[162949233]https://www.pivotaltracker.com/story/show/162949233
Screenshots (if appropriate)
Questions: