Merge 5e2c4f9 into 0c7e7e3

andela · Mar 15, 2019 · d0720a8 · d0720a8
2 parents 0c7e7e3 + 5e2c4f9
commit d0720a8
Show file tree

Hide file tree

Showing 7 changed files with 56 additions and 4 deletions.
diff --git a/controllers/articlesController.js b/controllers/articlesController.js
@@ -1,5 +1,6 @@
 import models from '../models';
 import Response from '../helpers/responseHelper';
+import articleHelpers from '../helpers/articleHelpers';
 import { STATUS } from '../helpers/constants';
 
 /**
@@ -22,8 +23,9 @@ export default class ArticlesController {
     const {
       title, body, description,
     } = req.body;
+    const readTime = articleHelpers.articleReadTime(req.body);
     const content = {
-      title, body, description, slug, authorId,
+      title, body, description, slug, authorId, readTime
     };
     try {
       const article = await models.Article.create(content);

diff --git a/database/migrations/20190305135521-create-articles.js b/database/migrations/20190305135521-create-articles.js
@@ -19,6 +19,9 @@ export default {
     description: {
       type: Sequelize.STRING
     },
+    readTime: {
+      type: Sequelize.STRING
+    },
     /**
        * @todo include tagId for articles tagList in tagList model
        */

diff --git a/helpers/articleHelpers.js b/helpers/articleHelpers.js
@@ -2,6 +2,8 @@ import models from '../models';
 
 const { Op } = models.Sequelize;
 
+let readTime;
+
 export default {
   findArticleByAuthorId: async (authorId, title) => {
     try {
@@ -24,4 +26,21 @@ export default {
       return error;
     }
   },
+  articleReadTime: (articleBody) => {
+    try {
+      const defaultArticleLength = 250;
+      const articleLength = articleBody.body.split(' ').length;
+      if (articleLength <= defaultArticleLength) {
+        readTime = '1 minute read';
+        return readTime;
+      }
+      readTime = Math.round(articleLength / defaultArticleLength);
+      if (readTime === 1) {
+        return `${readTime} minute read`;
+      }
+      return `${readTime} minutes read`;
+    } catch (err) {
+      return err;
+    }
+  }
 };
diff --git a/middlewares/authenticate.js b/middlewares/authenticate.js
@@ -19,10 +19,9 @@ import { STATUS } from '../helpers/constants';
 function authenticate(request, response, next) {
   // Get auth header value
   const bearer = request.headers.authorization;
-  if (!bearer) return next(createError(STATUS.UNATHORIZED, 'You are unauthorized to access the requested resource. Please log in.'));
+  if (!bearer) return next(createError(401, 'You are unauthorized to access the requested resource. Please log in.'));
 
   const token = bearer.split(' ')[1];
-
   return jwt.verify(token, env('APP_KEY'), (err, decoded) => {
     if (err || !decoded) return next(createError(STATUS.UNATHORIZED, 'Authentication failure: Invalid access token.'));
 

diff --git a/models/Article.js b/models/Article.js
@@ -25,6 +25,7 @@ const Article = (sequelize, DataTypes) => {
         defaultValue: sequelize.NOW
       },
       description: DataTypes.STRING,
+      readTime: DataTypes.STRING,
       updatedAt: {
         allowNull: true,
         type: DataTypes.DATE,

diff --git a/test/unit/middlewares/articlesMiddleware.test.js b/test/unit/middlewares/articlesMiddleware.test.js
@@ -6,6 +6,7 @@ import app from '../../../index';
 import models from '../../../models';
 import logger from '../../../helpers/logger';
 import { STATUS } from '../../../helpers/constants';
+import articleHelpers from '../../../helpers/articleHelpers';
 
 logger.log('The test is running');
 chai.use(chaiHttp);
@@ -262,4 +263,31 @@ describe('API endpoint: /api/articles (Middleware test)', () => {
       });
     });
   });
+
+  describe('POST: /api/v1/articles', () => {
+    describe('Article read time', () => {
+      it('Should create an article with the minute(s) it will take to read it', (done) => {
+        const article = {
+          title: faker.random.words(),
+          description: 'dehjfjdh',
+          body: 'sentence I make all over again'
+        };
+        const readTime = articleHelpers.articleReadTime(article.body);
+        article.time = readTime;
+        chai
+          .request(app)
+          .post('/api/v1/articles')
+          .send(article)
+          .set({ Authorization: `Bearer ${dummyUser.token}` })
+          .end((err, res) => {
+            expect(res).to.have.status(CREATED);
+            expect(res.body).to.be.an('object');
+            expect(res.body).to.haveOwnProperty('code').to.equal(CREATED);
+            expect(res.body.data.slug).to.be.a('string');
+            expect(res.body).to.contain(readTime);
+            done();
+          });
+      });
+    });
+  });
 });
diff --git a/test/unit/middlewares/socialAuth.test.js b/test/unit/middlewares/socialAuth.test.js
@@ -13,7 +13,7 @@ describe('social authentication', () => {
         emails: [{ value: 'testing@test1.com' }]
       },
     };
-    it('should hit socail authentication API', async () => {
+    it('should hit social authentication API', async () => {
       const facebookUserInfo = generateOrFindUser(
         verifyCallback.accessToken,
         verifyCallback.refreshToken,