-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#164198181 Validates signup parameters #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- install express-validator - create middleware to validate parameters - create middleware to handle validation result - send appropriate validation mesages and status code [Finishes #164198181]
houndci-bot
reviewed
Mar 7, 2019
aanchirinah
suggested changes
Mar 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job done @valenstical , kindly attend to my requested changes
- change file names from kebab case to camel case to follow the expected convention
devdbrandy
suggested changes
Mar 8, 2019
- add jsdoc to expressValidatorFormater for better understanding of the function purpose.
devdbrandy
approved these changes
Mar 8, 2019
Looks good to me. |
aanchirinah
approved these changes
Mar 8, 2019
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR validates registration/signup parameters before sending control over to the user controller.
Description of Task to be completed
How should this be manually tested
Prerequisite: Postgres
Modify
.env
file with your db credentialsRun migrations with
npm run migrate
Spin up the server by running
npm run start:dev
on your terminalMake a POST request to
localhost:3000/api/v1/users
respectively with Postman.❗️ Important: Provide user payload when making request, sample below:
NOTE: To run test locally, create
.env.test
file. Run command:cp .env.example .env.test
Any background context you want to provide
N/A
What are the relevant pivotal tracker stories
#164198181
Screenshots
N/A
-- Template format by @devdbrandy