Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#164428066 Implement bookmark or favourite article notifications #45

Merged
merged 15 commits into from
Mar 13, 2019

Conversation

shaolinmkz
Copy link
Contributor

@shaolinmkz shaolinmkz commented Mar 11, 2019

What does this PR do?

Have notifications sent to users via email and in-app for bookmarked or favourite article

Description of Task to be completed?

Having the following tasks implemented:

  • Notify user via email when a comment is made on a favourite or bookmarked article
  • Notify user in-app when a comment is made on a favourite or bookmarked article

How should this be manually tested?

  1. Clone this branch.
  2. Run npm install to install the dependencies.
  3. Run npm test to run the tests.
  4. Run npm run start:dev to start the server and use Postman to test manually.

What are the relevant pivotal tracker stories?

#164428066

Screenshot

Screenshot 2019-03-13 at 2 24 04 AM

@shaolinmkz shaolinmkz added the wip Work in Progress label Mar 11, 2019
@shaolinmkz shaolinmkz removed the wip Work in Progress label Mar 12, 2019
@@ -0,0 +1,39 @@
import db from '../database/models';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition for rule 'prettier/prettier' was not found prettier/prettier

@@ -0,0 +1,22 @@
export default (sequelize, DataTypes) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition for rule 'prettier/prettier' was not found prettier/prettier

@@ -0,0 +1,31 @@
export default {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition for rule 'prettier/prettier' was not found prettier/prettier

@shaolinmkz shaolinmkz merged commit 9f99dd7 into develop Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants