#165174100 Edit-Delete article #28

itsgratien · 2019-04-09T11:05:36Z

What does this PR do?

update and delete articles

Description of Task to be completed?

this PR allows a user to edit/update his article and delete an article. user who is allowed to update or delete article is the one who created an article and must be authenticated.
This PR also has the following endpoints:

PUT /api/articles/:articleId
DELETE /api/articles/:articleId
GET /api/articles/:articleId (get single article)

How should this be manually tested?

open your postman
in your URL, update article http://localhost:3000/api/articles/1
makesure that form is set to form-data
for example in your form must have
{'title':'article1', 'body':'this article body' , 'tag':'programming,nodejs', 'image':'image.jpg'}
then run

Screenshoots

What are the relevant pivotal tracker stories?

165174100

houndci-bot · 2019-04-09T11:56:24Z

routes/api/article.js

+router.put('/:articleId', auth, checkingArticle,multer, Article.updateArticle);
+// @Method Delete
+// @desc deleting articles
+router.delete('/:articleId', auth, checkingArticle,Article.deleteArticle);


A space is required after ',' comma-spacing

houndci-bot · 2019-04-09T11:56:25Z

routes/api/article.js

@@ -11,5 +12,11 @@ router.post('/', auth, multer, Article.create);
 // @Method GET
 // @Desc get all created article
 router.get('/', Article.getArticle);
+// @Method PUT
+// @Desc update articles
+router.put('/:articleId', auth, checkingArticle,multer, Article.updateArticle);


A space is required after ',' comma-spacing

houndci-bot · 2019-04-09T14:41:57Z

controllers/user.js

@@ -58,6 +58,7 @@ class UserController {
    };
    return User.findOne({ where: { email: user.email } })
      .then((foundUser) => {
+        console.log('found user',foundUser);


A space is required after ',' comma-spacing

houndci-bot · 2019-04-09T15:21:38Z

test/3-artilcle.js

+
+chai.use(chaiHttp);
+chai.should();
+const Article = models.article;


'Article' is assigned a value but never used no-unused-vars

houndci-bot · 2019-04-09T15:33:46Z

test/3-artilcle.js

+    res.should.have.status(403);
+    done();
+  })
+});


Expected indentation of 2 spaces but found 0 indent

houndci-bot · 2019-04-09T15:33:46Z

test/3-artilcle.js

+    }
+    res.should.have.status(403);
+    done();
+  })


Expected indentation of 6 spaces but found 2 indent
Missing semicolon semi

houndci-bot · 2019-04-09T15:33:46Z

test/3-artilcle.js

+      done(error);
+    }
+    res.should.have.status(403);
+    done();


Expected indentation of 8 spaces but found 4 indent

houndci-bot · 2019-04-09T15:33:46Z

test/3-artilcle.js

+    if(error){
+      done(error);
+    }
+    res.should.have.status(403);


Expected indentation of 8 spaces but found 4 indent

houndci-bot · 2019-04-09T15:33:47Z

test/3-artilcle.js

+  .end((error,res)=>{
+    if(error){
+      done(error);
+    }


Expected indentation of 8 spaces but found 4 indent

houndci-bot · 2019-04-09T15:33:48Z

test/3-artilcle.js

+ });
+ //@delete article
+ it("should return status code of 403 on deleting article",(done)=>{
+  chai.request(app)


Expected indentation of 4 spaces but found 2 indent

houndci-bot · 2019-04-09T15:33:48Z

test/3-artilcle.js

+    })
+ });
+ //@delete article
+ it("should return status code of 403 on deleting article",(done)=>{


A space is required after ',' comma-spacing
Expected indentation of 2 spaces but found 1 indent
Missing space after => arrow-spacing
Missing space before => arrow-spacing
Strings must use singlequote quotes

houndci-bot · 2019-04-09T15:33:48Z

test/3-artilcle.js

+      done();
+    })
+ });
+ //@delete article


Expected exception block, space or tab after '//' in comment spaced-comment
Expected indentation of 2 spaces but found 1 indent

houndci-bot · 2019-04-09T15:33:49Z

test/3-artilcle.js

+      res.should.have.status(404);
+      done();
+    })
+ });


Expected indentation of 2 spaces but found 1 indent

houndci-bot · 2019-04-09T15:33:49Z

test/3-artilcle.js

+      }
+      res.should.have.status(404);
+      done();
+    })


Expected indentation of 6 spaces but found 4 indent
Missing semicolon semi

houndci-bot · 2019-04-10T08:07:57Z

routes/api/article.js

@@ -11,5 +12,14 @@ router.post('/', auth, multer, Article.create);
 // @Method GET
 // @Desc get all created article
 router.get('/', Article.getArticle);
+//@Method GET
+//@desc get single article
+router.get('/:articleId',Article.singleArticle);


A space is required after ',' comma-spacing

houndci-bot · 2019-04-10T08:07:58Z

routes/api/article.js

@@ -11,5 +12,14 @@ router.post('/', auth, multer, Article.create);
 // @Method GET
 // @Desc get all created article
 router.get('/', Article.getArticle);
+//@Method GET
+//@desc get single article


Expected exception block, space or tab after '//' in comment spaced-comment

houndci-bot · 2019-04-10T08:07:58Z

routes/api/article.js

@@ -11,5 +12,14 @@ router.post('/', auth, multer, Article.create);
 // @Method GET
 // @Desc get all created article
 router.get('/', Article.getArticle);
+//@Method GET


Expected exception block, space or tab after '//' in comment spaced-comment

Paccy10 · 2019-04-10T08:57:02Z

@itsgracian your commit message is not following the conventions

blaisebakundukize · 2019-04-10T09:28:10Z

@itsgracian, I like the way you handled your tasks. But it would be better if you change your commit message because it does not follow our convention.

itsgratien · 2019-04-10T10:14:17Z

cool, let me change it

- it has PUT method (/api/articles/:articleId) - GET Method viewing single article (/api/articles/:articleId) - DELETE Method delete article (/api/articles/:articleId) [Delivers #165174100]

itsgratien added the WIP label Apr 9, 2019

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 9, 2019 11:05 Inactive

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from 21ecb89 to 98e12f8 Compare April 9, 2019 11:56

houndci-bot reviewed Apr 9, 2019

View reviewed changes

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 9, 2019 11:56 Inactive

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from 98e12f8 to cdd337a Compare April 9, 2019 11:58

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 9, 2019 11:59 Inactive

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from cdd337a to f3b294b Compare April 9, 2019 14:23

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 9, 2019 14:23 Inactive

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from f3b294b to 7590b3c Compare April 9, 2019 14:41

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 9, 2019 14:41 Inactive

houndci-bot reviewed Apr 9, 2019

View reviewed changes

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from 7590b3c to 59cb933 Compare April 9, 2019 15:21

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 9, 2019 15:21 Inactive

houndci-bot reviewed Apr 9, 2019

View reviewed changes

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from 59cb933 to 42028be Compare April 9, 2019 15:33

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 9, 2019 15:33 Inactive

houndci-bot reviewed Apr 9, 2019

View reviewed changes

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from 42028be to 5d94268 Compare April 9, 2019 15:47

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 9, 2019 15:47 Inactive

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from 5d94268 to 2119436 Compare April 9, 2019 15:51

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 9, 2019 15:52 Inactive

itsgratien added Ready for review and removed WIP labels Apr 9, 2019

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch 3 times, most recently from e57abef to 8b4843d Compare April 10, 2019 08:07

houndci-bot reviewed Apr 10, 2019

View reviewed changes

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 10, 2019 08:07 Inactive

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from 8b4843d to 9a230fa Compare April 10, 2019 08:20

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 10, 2019 08:20 Inactive

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from 9a230fa to 0b09b12 Compare April 10, 2019 08:46

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 10, 2019 08:46 Inactive

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from 0b09b12 to c0b1b85 Compare April 10, 2019 10:53

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-28 April 10, 2019 10:53 Inactive

itsgratien added the Finished label Apr 11, 2019

feature (article)update articles and delete article

655c849

- it has PUT method (/api/articles/:articleId) - GET Method viewing single article (/api/articles/:articleId) - DELETE Method delete article (/api/articles/:articleId) [Delivers #165174100]

itsgratien force-pushed the ft-editUpdateArticles-165174100 branch from c0b1b85 to 655c849 Compare April 11, 2019 09:52

itsgratien deployed to badass-ah-backend-stagin-pr-28 April 11, 2019 09:52 View deployment

ruganda merged commit 6ad27be into develop Apr 11, 2019

ruganda deleted the ft-editUpdateArticles-165174100 branch April 11, 2019 11:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#165174100 Edit-Delete article #28

#165174100 Edit-Delete article #28

itsgratien commented Apr 9, 2019 •

edited

Loading

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 10, 2019

houndci-bot Apr 10, 2019

houndci-bot Apr 10, 2019

Paccy10 commented Apr 10, 2019

blaisebakundukize commented Apr 10, 2019

itsgratien commented Apr 10, 2019

#165174100 Edit-Delete article #28

#165174100 Edit-Delete article #28

Conversation

itsgratien commented Apr 9, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Screenshoots

What are the relevant pivotal tracker stories?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Paccy10 commented Apr 10, 2019

blaisebakundukize commented Apr 10, 2019

itsgratien commented Apr 10, 2019

itsgratien commented Apr 9, 2019 •

edited

Loading