#164489943 getting article reading time #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paccy10
changed the title
Paccy10
force-pushed
the
ft-get-read-time-164489943
branch
from
e3e8408
to
a74c804
Compare
nakiwuge
suggested changes
Apr 15, 2019
There was a problem hiding this comment.
@Paccy10 good job on the implementation. Please consider adding the read time when the user retrieves all articles.
Also, when the article body is short the read time shows 0 mins consider refactoring the read time function to cater for seconds.
Paccy10
force-pushed
the
ft-get-read-time-164489943
branch
from
a74c804
to
eef5cf9
Compare
Paccy10
force-pushed
the
ft-get-read-time-164489943
branch
from
eef5cf9
to
e451403
Compare
Paccy10
force-pushed
the
ft-get-read-time-164489943
branch
from
e451403
to
361ffcc
Compare
-showing time it takes to read an article [Delivers #164489943]
Paccy10
force-pushed
the
ft-get-read-time-164489943
branch
from
361ffcc
to
1c949cf
Compare
nakiwuge
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR shows the time it takes to read an article
Description of Task to be completed?
Showing the user the number of minutes it will take him to read a specific article
How should this be manually tested?
http://localhost:3000/api/users/:idwith the id of the article and send aGETrequestWhat are the relevant pivotal tracker stories?
#164489943
Screenshots (if appropriate)
Response