#167891575 Implements Descriptive Signup/Registration Errors #15

meetKazuki · 2019-08-21T03:10:27Z

What does this PR do?

Implements validations during signup
Implements descriptive error messages during signup

Description of Task to be completed?

* Display error message when a user tries to signup with an already existing email
* Write tests
~~feature using Swagger~~

How should this manually be Tested?

git clone this repo
Checkout to this branch ft-signup-validation-167891575
Run npm i
Run npm test

What are the relevant Pivotal Tracker stories?

#167891575

Screenshots (if appropriate)

hound · 2019-08-21T12:02:25Z

src/database/models/index.js

@@ -21,7 +21,7 @@ if (config.use_env_variable) {
 }

 fs.readdirSync(__dirname)
-  .filter(file => (file
+  .filter((file) => (file


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

src/database/migrations/20190817131405-create-users.js

test/routes/auth.test.js

hound · 2019-08-22T03:24:12Z

test/routes/auth.test.js

@@ -0,0 +1,29 @@
+import chai, { should } from 'chai';
+import chaiHttp from 'chai-http';


'chaiHttp' is defined but never used no-unused-vars

test/routes/auth.test.js

hound · 2019-08-22T03:24:12Z

src/utils/capitalize.js

+  const formatWord = word
+    .toLowerCase()
+    .split(' ')
+    .map((f) => f.charAt(0).toUpperCase() + f.substring(1))


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2019-08-22T15:40:43Z

src/database/migrations/20190821105503-create-user.js

+      defaultValue: Sequelize.fn('now')
+    }
+  })),
+  down: (queryInterface) => queryInterface.dropTable('Users')


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2019-08-26T02:44:26Z

test/auth.test.js

+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.gender).to.eql(
+            'Male or Female is the accepted value'
+          );


Unexpected newline before ')' function-paren-newline

test/auth.test.js

hound · 2019-08-26T02:44:27Z

test/auth.test.js

+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.gender).to.eql(
+            'Male or Female is the accepted value'
+          );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T02:44:27Z

test/auth.test.js

+        .end((err, res) => {
+          expect(res).to.have.status(400);
+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.gender).to.eql(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T02:44:27Z

test/auth.test.js

+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.dob).to.eql(
+            'Users must be 18 and above'
+          );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T02:44:28Z

test/auth.test.js

+        .end((err, res) => {
+          expect(res).to.have.status(400);
+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.password).to.eql(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T02:44:28Z

test/auth.test.js

+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.email).to.eql(
+            'Email address is invalid'
+          );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T02:44:28Z

test/auth.test.js

+        .end((err, res) => {
+          expect(res).to.have.status(400);
+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.email).to.eql(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T02:44:28Z

test/auth.test.js

+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.lastName).to.eql(
+            'Last name should only contain alphabets'
+          );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T02:44:28Z

test/auth.test.js

+        .end((err, res) => {
+          expect(res).to.have.status(400);
+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.lastName).to.eql(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T02:49:31Z

src/middlewares/validator.js

+          accumulator[key] = value.msg;
+          return accumulator;
+        }, {},
+      );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T02:49:31Z

src/middlewares/validator.js

+    req = { ...req, ...matchedData(req) };
+
+    if (!errors.isEmpty()) {
+      const mapErrors = Object.entries(errors.mapped()).reduce(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T02:49:32Z

src/validation/auth.js

+      .isAlphanumeric()
+      .withMessage(
+        'Password must be alphanumeric and not be less than 8 characters'
+      ),


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T02:49:32Z

src/validation/auth.js

+      .isLength({ min: 8, })
+      .withMessage('Password must be alphanumeric and not be less than 8 characters')
+      .isAlphanumeric()
+      .withMessage(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T02:49:32Z

test/auth.test.js

+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.lastName).to.eql(
+            'Last name should be between 2 to 15 characters'
+          );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T02:49:32Z

test/auth.test.js

+        .end((err, res) => {
+          expect(res).to.have.status(400);
+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.firstName).to.eql(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T02:49:32Z

test/auth.test.js

+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.firstName).to.eql(
+            'First name should be between 2 to 15 characters'
+          );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T02:49:33Z

test/auth.test.js

+        .end((err, res) => {
+          expect(res).to.have.status(400);
+          expect(res.body.message).to.eql('Validation Error!');
+          expect(res.body.data.firstName).to.eql(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T02:49:33Z

test/auth.test.js

+          expect(res).to.have.status(409);
+          expect(res.body.message).to.eql(
+            'User with email address already exist',
+          );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T02:49:33Z

test/auth.test.js

+        .send(user)
+        .end((err, res) => {
+          expect(res).to.have.status(409);
+          expect(res.body.message).to.eql(


Unexpected newline after '(' function-paren-newline

Pomile

Nice Job!
I like your creativity. However, I think your middleware/validator.js could be simpler. Please check express-validator website.

[Starts #167891575]

meetKazuki added the wip label Aug 21, 2019

meetKazuki requested review from max-wel, Pomile, tvpeter and femitj August 21, 2019 03:10

meetKazuki force-pushed the ft-signup-validation-167891575 branch from 4b48cfa to d2ec6fe Compare August 21, 2019 12:02

hound bot reviewed Aug 21, 2019

View reviewed changes

meetKazuki force-pushed the ft-signup-validation-167891575 branch from d2ec6fe to 6bcbf8b Compare August 22, 2019 03:24

hound bot reviewed Aug 22, 2019

View reviewed changes

meetKazuki force-pushed the ft-signup-validation-167891575 branch from 6bcbf8b to febcfd3 Compare August 22, 2019 15:40

hound bot reviewed Aug 22, 2019

View reviewed changes

meetKazuki added ready for review and removed wip labels Aug 22, 2019

meetKazuki force-pushed the ft-signup-validation-167891575 branch 6 times, most recently from 05593a7 to aa25c73 Compare August 26, 2019 02:44

hound bot reviewed Aug 26, 2019

View reviewed changes

meetKazuki force-pushed the ft-signup-validation-167891575 branch from aa25c73 to 7223882 Compare August 26, 2019 02:49

hound bot reviewed Aug 26, 2019

View reviewed changes

meetKazuki requested a review from daniellamarr August 26, 2019 03:12

meetKazuki force-pushed the ft-signup-validation-167891575 branch from 7223882 to 09e171c Compare August 26, 2019 08:13

Pomile reviewed Aug 26, 2019

View reviewed changes

meetKazuki force-pushed the ft-signup-validation-167891575 branch from 09e171c to 5e66a6a Compare August 26, 2019 09:20

feat(validation): implement signup validation

8e9ea9f

[Starts #167891575]

meetKazuki force-pushed the ft-signup-validation-167891575 branch from 5e66a6a to 8e9ea9f Compare August 26, 2019 09:22

daniellamarr approved these changes Aug 26, 2019

View reviewed changes

daniellamarr merged commit 36f9a58 into develop Aug 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#167891575 Implements Descriptive Signup/Registration Errors #15

#167891575 Implements Descriptive Signup/Registration Errors #15

meetKazuki commented Aug 21, 2019 •

edited

Loading

hound bot Aug 21, 2019

hound bot Aug 22, 2019

hound bot Aug 22, 2019

hound bot Aug 22, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

hound bot Aug 26, 2019

Pomile left a comment •

edited

Loading

		@@ -0,0 +1,29 @@
		import chai, { should } from 'chai';
		import chaiHttp from 'chai-http';

#167891575 Implements Descriptive Signup/Registration Errors #15

#167891575 Implements Descriptive Signup/Registration Errors #15

Conversation

meetKazuki commented Aug 21, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this manually be Tested?

What are the relevant Pivotal Tracker stories?

Screenshots (if appropriate)

hound bot Aug 21, 2019

Choose a reason for hiding this comment

hound bot Aug 22, 2019

Choose a reason for hiding this comment

hound bot Aug 22, 2019

Choose a reason for hiding this comment

hound bot Aug 22, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

Pomile left a comment • edited Loading

Choose a reason for hiding this comment

meetKazuki commented Aug 21, 2019 •

edited

Loading

Pomile left a comment •

edited

Loading