#167891600 Update Travel Request #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-wel
force-pushed
the
ft-edit-travel-request-167891600
branch
from
01a9a9b
to
7498a1b
Compare
max-wel
force-pushed
the
ft-edit-travel-request-167891600
branch
from
7498a1b
to
0eb719e
Compare
femitj
approved these changes
Sep 6, 2019
max-wel
force-pushed
the
ft-edit-travel-request-167891600
branch
7 times, most recently
from
6f4e6f5
to
49e36ce
Compare
- write tests - add input validations - add route and controller logic [Finishes #167891600]
max-wel
force-pushed
the
ft-edit-travel-request-167891600
branch
from
49e36ce
to
ea32faf
Compare
daniellamarr
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates travel request
Description of Task to be completed?
How should this be manually tested?
ft-edit-travel-request-167891600npm run migratenpm run devstartcommand in the terminallocalhost:3000/api/v1/trips/{tripId}Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#167891600
Screenshots (if appropriate)