Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167891584 Notifications for new travel request(in-app notification) #58

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Pomile
Copy link
Collaborator

@Pomile Pomile commented Sep 10, 2019

What does this PR do?

Send in-app message to the admin user.

Description of Task to be completed?

  • Install socket.io and sockect.io-client
  • Create an in-app client
  • Create socket io server
  • Modify new trip request method
  • create html page to test this feature

How should this be manually tested?

Unit test
  1. Clone the project repository
  2. Cd into the project repository
  3. Run git pull
  4. Run git checkout ft-inAppNotification-configOpt-endpoint-167891584
  5. Run npm install
  6. Create database database_name
  7. Create .env file
  8. Run npm test
Development test with Postman
  1. Run npm run devstart
  2. launch your browser and enter /api/v1/trips/test/in_app
  3. Launch postman
  4. Create a new post request with /api/v1/trips
  5. Add a request body
{

    "type": "oneway",
    "from": "xxxxxxxxxxxxxxxxx",
    "departureDate": "2000-09-09",
    "reason": "Just wanna travel",
    "destination":
    {
      "to": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
      "accomodation": "xxxxxxxxxxxxxxxxxxxxxxxxxxxx"
    }
  } 
  1. Add authorization(token) in the request header.
  2. Hit send

What are the relevant pivotal tracker stories?

#167891584

Any background context you want to add?

Nil

Screenshots

inAppPost
inApp

@Pomile Pomile force-pushed the ft-inAppNotification-forNewTravelRequest-167891584 branch from 91484ff to f26d807 Compare September 10, 2019 13:30
@Pomile Pomile changed the title #167891584 Notifications for new travel request(in-app) #167891584 Notifications for new travel request(in-app notification) Sep 10, 2019
@Pomile Pomile added the wip label Sep 10, 2019
@Pomile Pomile force-pushed the ft-inAppNotification-forNewTravelRequest-167891584 branch from f26d807 to f41df56 Compare September 11, 2019 15:04
@Pomile Pomile force-pushed the ft-inAppNotification-forNewTravelRequest-167891584 branch 10 times, most recently from f2526b2 to 92c5dd4 Compare September 14, 2019 19:03
</i>
Start Location</div>
<div class="dataclip-body-line">
>>>>>>> feat(inApp-notification): Implement in-app notification feature for new
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 52, 57 & 66 have conflict you are yet to resolve.

@Pomile Pomile force-pushed the ft-inAppNotification-forNewTravelRequest-167891584 branch from 92c5dd4 to fa94d62 Compare September 17, 2019 03:37
travel request

- [x] Install socket.io and sockect.io-client
- [x] Create in-app client
- [x] Create sockect io server
- [x] Create endpoint that test inapp feature from through a browser
- [x] Modify new trip request method

[Finishes #167891584]
@Pomile Pomile force-pushed the ft-inAppNotification-forNewTravelRequest-167891584 branch from fa94d62 to 34f9819 Compare September 17, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants