#168781679 User Login #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainmateso
force-pushed
the
ft-user-login-168781679
branch
5 times, most recently
from
63f3f8b
to
e77d5b3
Compare
alainmateso
requested review from
ngireric123,
nignanthomas,
Cheza-Dzabala,
sabin18 and
nakiwuge
alainmateso
force-pushed
the
ft-user-login-168781679
branch
4 times, most recently
from
409cfbe
to
3765702
Compare
- creates endpoint for user to login - gives user a token upon signin [Finishes#168781679]
alainmateso
force-pushed
the
ft-user-login-168781679
branch
from
3765702
to
6b17d8c
Compare
alainmateso
force-pushed
the
ft-user-login-168781679
branch
from
6b17d8c
to
e269ec5
Compare
ngireric123
approved these changes
Oct 10, 2019
nignanthomas
suggested changes
Oct 10, 2019
There was a problem hiding this comment.
Great job @alainmateso so far
Just a few changes though
- Remove that unncessary variable in
.env.example - Update the PR body to the new
loginendpoint url/api/v1/users/login - Update the screenshots too
alainmateso
force-pushed
the
ft-user-login-168781679
branch
from
e269ec5
to
9a44a3f
Compare
nignanthomas
approved these changes
Oct 10, 2019
Cheza-Dzabala
approved these changes
Oct 10, 2019
nakiwuge
reviewed
Oct 10, 2019
|
|
||
| static async signIn(req, res) { | ||
| const { email, password } = req.body; | ||
| const user = await models.users.findOne({ where: { email } }); |
nakiwuge
reviewed
Oct 10, 2019
| const user = await models.users.findOne({ where: { email } }); | ||
| if (!user) { | ||
| return responseError(res, 400, strings.users.error.LOGIN_FAILURE); | ||
| } |
nakiwuge
reviewed
Oct 10, 2019
| import app from '../index'; | ||
| import strings from '../utils/stringsUtil'; | ||
| import mockData from './mockData/mockData'; | ||
|
|
nakiwuge
suggested changes
Oct 10, 2019
There was a problem hiding this comment.
Good job @alainmateso . The feature works as expected just a few changes are required to improve readability.
- creates endpoint for user to login - gives user a token upon signin - adheres to the current structre [Finishes#168781679]
alainmateso
force-pushed
the
ft-user-login-168781679
branch
from
9a44a3f
to
29d4629
Compare
nakiwuge
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add user login functionality.
Description of Task to be completed?
How should this be manually tested?
npm installsequelize db:migratesequelize db:seed:allnpm run devPOSTrequest tohttp://localhost:3000/api/v1/users/loginAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#168781679
Screenshots (if appropriate)
Questions:
N/A