#168781705 - Edit trip request #34

ngireric123 · 2019-10-25T08:23:59Z

[starts #168781705]

What does this PR do?

Update trip request

Description of Task to be completed?

added modify controller
added request middleware
added routes

How should this be manually tested?

Clone the repository from here
Browse to the repo directory
navigate to Ft-update-request-168781705 branch
Run npm install
run sequelize db:migrate
run sequelize db:seed:all
run npm run dev

- To Search Requests

If you are logged in
Send a PATCH request to http://localhost:port/api/v1/requests/:ID

Postman body example

{
	"typeId": 3,
	"locationId": 1,
	
	"destinations": [
		{
			"id": 1,
			"reasons": "visit andela"
		},
		{
			"id":2,
		"reasons": "visit andela nigeria office"
		}
		]
}

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#168781705

Screenshots (if appropriate)

Questions:

src/routes/api/requests.js

alainmateso

Good Job @ngireric123 . Kindly make your error messages descriptive to tell the user what exactly they are doing it wrong. Also, make a validation for the params id because when I pass an incorrect id format the app breaks.

nignanthomas

Great job @ngireric123 so far. It was a long road.

However, I suggest you have more descriptive error messages.
eg: You are not the owner of this request-id,
or for destinations' id => You are not the owner of this destination id.
In short, more descriptive messages.

Kindly make sure you test your feature extensively, why has the test coverage dropped by 2.5%?

Thanks

- added test - validation [finishes #168781705]

nakiwuge · 2019-10-30T08:11:11Z

src/middlewares/inputValidation.js

@@ -3,6 +3,7 @@ import models from '../database/models';
 import responseError from '../utils/responseError';
 import strings from '../utils/stringsUtil';

+


Remove this line

nakiwuge · 2019-10-30T08:11:49Z

src/middlewares/inputValidation.js

+  static validateRequest(req, res, next) {
+    const data = req.body;
+    let minimumItems = 1;
+    let maximumItems = 30;


Add an empty line

nakiwuge · 2019-10-30T08:12:02Z

src/middlewares/inputValidation.js

+    let maximumItems = 30;
+    if (data.typeId === 1 || data.typeId === 2) {
+      maximumItems = 1;
+    }


Add an empty line

nakiwuge · 2019-10-30T08:13:13Z

src/middlewares/inputValidation.js

+    }
+    if (data.typeId === 3) {
+      minimumItems = 2;
+    }


Add a new line

nakiwuge · 2019-10-30T08:26:12Z

src/middlewares/request.js

+  async selectPending(req, res, next) {
+    const userId = req.user.payload.id;
+    const id = parseInt(req.params.id, 10);
+    const requester = await requests.findOne({


I assume you are finding a request, not a requester. Create a helper function for this query.

nakiwuge · 2019-10-30T08:32:30Z

src/middlewares/request.js

+
+  async validateBody(req, res, next) {
+    const { id } = req.params;
+    const destination = req.body;


Are you using this cont anywhere? If not remove it.

nakiwuge · 2019-10-30T08:32:50Z

src/middlewares/request.js

+      }).then(destination => {
+        if (!destination) {
+          return responseError(res, 403, `Destination of id ${element.id} does not belong to this request`);
+


Remove this line

nakiwuge

@ngireric123 good job on the implementation however kindly work on the feedback below.

Test validateRequest.js function to increase coverage.
Ensure that a user can edit a return date
Go through the comments I have left on your pr

- squash commit [finishes #168781705]

hound bot reviewed Oct 25, 2019

View reviewed changes

src/routes/api/requests.js Outdated Show resolved Hide resolved

src/routes/api/requests.js Outdated Show resolved Hide resolved

ngireric123 added the WIP Work In Progress label Oct 25, 2019

ngireric123 changed the title ~~ft(edit trip request): user should be able to edit his/her trip request~~ #168781705 - Edit trip request Oct 25, 2019

ngireric123 added Ready For Review and removed WIP Work In Progress labels Oct 28, 2019

ngireric123 force-pushed the Ft-update-request-168781705 branch 2 times, most recently from 7553bf1 to 7dadd80 Compare October 28, 2019 20:49

ngireric123 requested review from sabin18, alainmateso and nakiwuge October 28, 2019 20:54

ngireric123 force-pushed the Ft-update-request-168781705 branch 2 times, most recently from ee4873f to fdfb06b Compare October 29, 2019 07:14

ngireric123 requested review from Cheza-Dzabala and nignanthomas October 29, 2019 07:26

alainmateso suggested changes Oct 29, 2019

View reviewed changes

ngireric123 requested review from alainmateso and removed request for nakiwuge, Cheza-Dzabala and sabin18 October 29, 2019 11:53

nignanthomas suggested changes Oct 29, 2019

View reviewed changes

ft(update trip request): user should be able update trip request

2cde6f6

- added test - validation [finishes #168781705]

ngireric123 force-pushed the Ft-update-request-168781705 branch from fdfb06b to a86dc9b Compare October 30, 2019 07:17

nakiwuge reviewed Oct 30, 2019

View reviewed changes

src/middlewares/inputValidation.js

}

if (data.typeId === 3) {

minimumItems = 2;

}

Copy link

Contributor

nakiwuge Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line

nakiwuge reviewed Oct 30, 2019

View reviewed changes

nakiwuge suggested changes Oct 30, 2019

View reviewed changes

ft(update trip request): user should be able update trip request

66706f4

- squash commit [finishes #168781705]

ngireric123 force-pushed the Ft-update-request-168781705 branch from a86dc9b to 66706f4 Compare October 30, 2019 13:36

alainmateso approved these changes Oct 30, 2019

View reviewed changes

nignanthomas approved these changes Oct 30, 2019

View reviewed changes

nakiwuge approved these changes Oct 30, 2019

View reviewed changes

nakiwuge merged commit bdd3e5a into develop Oct 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#168781705 - Edit trip request #34

#168781705 - Edit trip request #34

ngireric123 commented Oct 25, 2019

alainmateso left a comment

nignanthomas left a comment •

edited

Loading

nakiwuge Oct 30, 2019

nakiwuge Oct 30, 2019

nakiwuge Oct 30, 2019

nakiwuge Oct 30, 2019

nakiwuge Oct 30, 2019 •

edited

Loading

nakiwuge Oct 30, 2019

nakiwuge Oct 30, 2019

nakiwuge left a comment •

edited

Loading

		@@ -3,6 +3,7 @@ import models from '../database/models';
		import responseError from '../utils/responseError';
		import strings from '../utils/stringsUtil';

#168781705 - Edit trip request #34

#168781705 - Edit trip request #34

Conversation

ngireric123 commented Oct 25, 2019

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Questions:

alainmateso left a comment

Choose a reason for hiding this comment

nignanthomas left a comment • edited Loading

Choose a reason for hiding this comment

nakiwuge Oct 30, 2019

Choose a reason for hiding this comment

nakiwuge Oct 30, 2019

Choose a reason for hiding this comment

nakiwuge Oct 30, 2019

Choose a reason for hiding this comment

nakiwuge Oct 30, 2019

Choose a reason for hiding this comment

nakiwuge Oct 30, 2019 • edited Loading

Choose a reason for hiding this comment

nakiwuge Oct 30, 2019

Choose a reason for hiding this comment

nakiwuge Oct 30, 2019

Choose a reason for hiding this comment

nakiwuge left a comment • edited Loading

Choose a reason for hiding this comment

nignanthomas left a comment •

edited

Loading

nakiwuge Oct 30, 2019 •

edited

Loading

nakiwuge left a comment •

edited

Loading