#168781692 add and view comment #40

ngireric123 · 2019-10-31T08:16:01Z

What does this PR do?

Add and view comments

Description of Task to be completed?

add the possibility for line manager and owner of the request to add a comment on the request
add the possibility for line manager and owner of the request to view a comment on the request

How should this be manually tested?

Browse to the repo directory
navigate to Ft-comment-168781692 branch
Run npm install
run sequelize db:migrate
run sequelize db:seed:all
run npm run dev

Any background context you want to provide?

To add a comment

In Postman Provide a login bearer token
Fill the body with comment field
send a POST request to http://localhost:<:port>/api/v1/comments/:id

To view a comment

In Postman Provide a login bearer token
send a GET request to http://localhost:<:port>/api/v1/comments/:id

What are the relevant pivotal tracker stories?

#168781692

Screenshots (if appropriate)

Questions:

N/A

alainmateso

Great job Eric. Kindly change the message that you return when posting a comment and make it comment-related. I think the user is posting a comment not updating a request. Other than that, well done.

src/routes/api/comments.js

nakiwuge · 2019-11-01T07:39:41Z

src/controllers/commentsController.js

+  static async addComment(req, res) {
+    const { comment } = req.body;
+    const { id } = req.user.payload;
+    const requestId = parseInt(req.params.id, 10);


Add a new line here

nakiwuge · 2019-11-01T07:40:05Z

src/controllers/commentsController.js

+    }
+  }
+
+


Remove this line

nakiwuge · 2019-11-01T07:41:44Z

src/controllers/commentsController.js

+    try {
+      const requestId = parseInt(req.params.id, 10);
+      const comments = await models.comments.findAll({
+        where: { requestId }


This gets all comments on a request even the soft deleted ones. Add a condition to get comments only when the deleted= false

nakiwuge · 2019-11-01T07:43:58Z

src/middlewares/commentMiddleware.js

+
+const { requests, users } = models;
+
+const commentMiddle = {


Get this a better name please

nakiwuge · 2019-11-01T07:44:44Z

src/routes/api/comments.js

+import commentMiddleware from '../../middlewares/commentMiddleware';
+
+const router = new Router();
+


remove this line

nakiwuge · 2019-11-01T07:44:53Z

src/routes/api/comments.js

+const router = new Router();
+
+const { addComment, getComments } = commentsController;
+


remove this line

nakiwuge · 2019-11-01T07:45:08Z

src/routes/api/comments.js

+const { addComment, getComments } = commentsController;
+
+const { validateComment } = InputValidation;
+


remove this line

nakiwuge · 2019-11-01T07:45:52Z

src/tests/comment.spec.js

+chai.use(chaiHttp);
+
+const id = mockdata.verifiedUser1.id;
+


remove this line

nakiwuge · 2019-11-01T07:46:41Z

src/controllers/commentsController.js

+      return res.send(error);
+    }
+  }
+


remove this line

nakiwuge

@ngireric123 good job. Kindly work on the feedback below.

Return the user object you can return id, username and email when retrieving comments
Add your endpoints to swagger
Check out the comments I have left on the pr

- create one endpoint for add/ view comment - create one controller for changeStatus - create a helper for comment - create a routes for API [starts #168781692]

ngireric123 added the WIP Work In Progress label Oct 31, 2019

ngireric123 changed the title ~~feature(add_comment): add and view comment~~ #168781692 add and view comment Oct 31, 2019

ngireric123 force-pushed the Ft-comment-168781692 branch from 20bd930 to 51ed07e Compare October 31, 2019 16:41

ngireric123 added Ready For Review and removed WIP Work In Progress labels Oct 31, 2019

ngireric123 requested review from alainmateso and sabin18 October 31, 2019 16:43

alainmateso approved these changes Oct 31, 2019

View reviewed changes

alainmateso reviewed Oct 31, 2019

View reviewed changes

src/routes/api/comments.js Outdated Show resolved Hide resolved

sabin18 approved these changes Oct 31, 2019

View reviewed changes

ngireric123 force-pushed the Ft-comment-168781692 branch from 1f56e94 to 472f294 Compare October 31, 2019 18:57

nakiwuge reviewed Nov 1, 2019

View reviewed changes

src/controllers/commentsController.js Outdated

}

}

Copy link

Contributor

nakiwuge Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

nakiwuge reviewed Nov 1, 2019

View reviewed changes

src/tests/comment.spec.js

chai.use(chaiHttp);

const id = mockdata.verifiedUser1.id;

Copy link

Contributor

nakiwuge Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

nakiwuge reviewed Nov 1, 2019

View reviewed changes

src/controllers/commentsController.js

return res.send(error);

}

}

Copy link

Contributor

nakiwuge Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

nakiwuge suggested changes Nov 1, 2019

View reviewed changes

feature(add_comment): add and view comment

eac722b

- create one endpoint for add/ view comment - create one controller for changeStatus - create a helper for comment - create a routes for API [starts #168781692]

ngireric123 force-pushed the Ft-comment-168781692 branch from 472f294 to eac722b Compare November 1, 2019 08:46

nakiwuge approved these changes Nov 1, 2019

View reviewed changes

nakiwuge merged commit 9cd173d into develop Nov 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#168781692 add and view comment #40

#168781692 add and view comment #40

ngireric123 commented Oct 31, 2019 •

edited

Loading

alainmateso left a comment

nakiwuge Nov 1, 2019

nakiwuge Nov 1, 2019

nakiwuge Nov 1, 2019

nakiwuge Nov 1, 2019

nakiwuge Nov 1, 2019

nakiwuge Nov 1, 2019

nakiwuge Nov 1, 2019

nakiwuge Nov 1, 2019

nakiwuge Nov 1, 2019

nakiwuge left a comment

		import commentMiddleware from '../../middlewares/commentMiddleware';

		const router = new Router();

		const router = new Router();

		const { addComment, getComments } = commentsController;

		const { addComment, getComments } = commentsController;

		const { validateComment } = InputValidation;

#168781692 add and view comment #40

#168781692 add and view comment #40

Conversation

ngireric123 commented Oct 31, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Questions:

alainmateso left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nakiwuge left a comment

Choose a reason for hiding this comment

ngireric123 commented Oct 31, 2019 •

edited

Loading