#169469778 - Modify Search Fonctionality #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nignanthomas
force-pushed
the
ch-modify-search-169469778
branch
from
02cefa2
to
43807e9
Compare
- edit validationRequestSearch to search by username and origin/destination=string - create a middleware to search the locations ids matching the search queries - edit managerUserIdField to return the users matching the username in queries [Finishes #169469778]
nignanthomas
force-pushed
the
ch-modify-search-169469778
branch
from
43807e9
to
a2d55c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modify Search Finctionality to search by
username, not userIdandorigin/destination with strings.Description of Task to be completed?
How should this be manually tested?
npm installsequelize db:migratesequelize db:seed:allnpm run devTo Search Requests
Send a GET request to
http://localhost:port/api/v1/requests/manager/search?username=thomas&origin=kampalaSend a GET request to
http://localhost:port/api/v1/requests/username=thomas&destination=lagosAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#169469778
Screenshots (if appropriate)
Questions:
N/A