Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#170672722 - Live Notifications #84

Merged
merged 1 commit into from
Jan 14, 2020
Merged

#170672722 - Live Notifications #84

merged 1 commit into from
Jan 14, 2020

Conversation

nignanthomas
Copy link
Contributor

What does this PR do?

Live Notifications.

Description of Task to be completed?

  • Use socket to emit on notification.

How should this be manually tested?

  • Clone the repository from here
  • Browse to the repo directory
  • Navigate to ch-live-notifications-170672722branch
  • Run npm install
  • Run sequelize db:migrate
  • Run sequelize db:seed:all
  • Run npm run dev

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#170672722

Screenshots (if appropriate)

Questions:

N/A

@nignanthomas nignanthomas added the WIP Work In Progress label Jan 13, 2020
@nignanthomas nignanthomas self-assigned this Jan 13, 2020
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 12:35 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 5ffa2be to 1604276 Compare January 13, 2020 15:01
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 15:06 Inactive
@ngireric123 ngireric123 temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 13, 2020 15:13 Inactive
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 15:16 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 1604276 to 455fda4 Compare January 13, 2020 15:21
@ngireric123 ngireric123 temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 13, 2020 15:21 Inactive
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 15:24 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 455fda4 to f03bbfc Compare January 13, 2020 15:34
@ngireric123 ngireric123 temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 13, 2020 15:34 Inactive
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 15:35 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from f03bbfc to 542c768 Compare January 13, 2020 15:40
@ngireric123 ngireric123 temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 13, 2020 15:40 Inactive
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 15:41 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 542c768 to 0816185 Compare January 13, 2020 15:56
@ngireric123 ngireric123 temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 13, 2020 15:56 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 0816185 to 4f3f924 Compare January 13, 2020 17:06
@ngireric123 ngireric123 temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 13, 2020 17:06 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 4f3f924 to d48588b Compare January 13, 2020 17:18
@ngireric123 ngireric123 temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 13, 2020 17:18 Inactive
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 17:19 Inactive
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 17:24 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from d48588b to 55b7caf Compare January 13, 2020 17:33
@ngireric123 ngireric123 temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 13, 2020 17:34 Inactive
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 17:35 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 55b7caf to ca67941 Compare January 13, 2020 17:54
@ngireric123 ngireric123 temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 13, 2020 17:55 Inactive
@nignanthomas nignanthomas temporarily deployed to caret-bn-backend-staging January 13, 2020 18:11 Inactive
alainmateso
alainmateso approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@alainmateso alainmateso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @nignanthomas , kindly remove a few console.log I have mentioned

@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from f60f657 to 6092413 Compare January 14, 2020 08:42
@nignanthomas nignanthomas temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 14, 2020 08:42 Inactive
hound[bot]
hound bot reviewed Jan 14, 2020
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read property 'name' of null 
Cannot read property 'name' of null
TypeError: Cannot read property 'name' of null
    at checkForViolation (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:34:39)
    at CatchClause (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:65:17)
    at listeners.(anonymous function).forEach.listener (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach ()
    at Object.emit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at Traverser.enter [as _enter] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:865:28)

ngireric123
ngireric123 approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@ngireric123 ngireric123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 6092413 to 374b34c Compare January 14, 2020 09:29
hound[bot]
hound bot reviewed Jan 14, 2020
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read property 'name' of null 
Cannot read property 'name' of null
TypeError: Cannot read property 'name' of null
    at checkForViolation (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:34:39)
    at CatchClause (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:65:17)
    at listeners.(anonymous function).forEach.listener (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach ()
    at Object.emit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at Traverser.enter [as _enter] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:865:28)

@nignanthomas nignanthomas temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 14, 2020 09:30 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 374b34c to c7eab8d Compare January 14, 2020 10:08
hound[bot]
hound bot reviewed Jan 14, 2020
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read property 'name' of null 
Cannot read property 'name' of null
TypeError: Cannot read property 'name' of null
    at checkForViolation (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:34:39)
    at CatchClause (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:65:17)
    at listeners.(anonymous function).forEach.listener (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach ()
    at Object.emit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at Traverser.enter [as _enter] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:865:28)

@nignanthomas nignanthomas temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 14, 2020 10:08 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from c7eab8d to 8d9a350 Compare January 14, 2020 10:27
hound[bot]
hound bot reviewed Jan 14, 2020
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read property 'name' of null 
Cannot read property 'name' of null
TypeError: Cannot read property 'name' of null
    at checkForViolation (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:34:39)
    at CatchClause (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:65:17)
    at listeners.(anonymous function).forEach.listener (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach ()
    at Object.emit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at Traverser.enter [as _enter] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:865:28)

@nignanthomas nignanthomas temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 14, 2020 10:27 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 8d9a350 to 0eaaaaa Compare January 14, 2020 11:56
hound[bot]
hound bot reviewed Jan 14, 2020
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read property 'name' of null 
Cannot read property 'name' of null
TypeError: Cannot read property 'name' of null
    at checkForViolation (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:34:39)
    at CatchClause (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:65:17)
    at listeners.(anonymous function).forEach.listener (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach ()
    at Object.emit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at Traverser.enter [as _enter] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:865:28)

@nignanthomas nignanthomas temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 14, 2020 11:56 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from 0eaaaaa to d34bada Compare January 14, 2020 12:29
hound[bot]
hound bot reviewed Jan 14, 2020
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read property 'name' of null 
Cannot read property 'name' of null
TypeError: Cannot read property 'name' of null
    at checkForViolation (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:34:39)
    at CatchClause (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:65:17)
    at listeners.(anonymous function).forEach.listener (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach ()
    at Object.emit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at Traverser.enter [as _enter] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:865:28)

@nignanthomas nignanthomas temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 14, 2020 12:29 Inactive
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from d34bada to e97b4a3 Compare January 14, 2020 12:44
hound[bot]
hound bot reviewed Jan 14, 2020
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read property 'name' of null 
Cannot read property 'name' of null
TypeError: Cannot read property 'name' of null
    at checkForViolation (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:34:39)
    at CatchClause (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:65:17)
    at listeners.(anonymous function).forEach.listener (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach ()
    at Object.emit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at Traverser.enter [as _enter] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:865:28)

@nignanthomas nignanthomas temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 14, 2020 12:44 Inactive
@nignanthomas
chore(notifications): Live Notifications
a4316d7 
- use socket to emit on notification

[Finishes #]
@nignanthomas nignanthomas force-pushed the ch-live-notifications-170672722 branch from e97b4a3 to a4316d7 Compare January 14, 2020 15:01
hound[bot]
hound bot reviewed Jan 14, 2020
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read property 'name' of null 
Cannot read property 'name' of null
TypeError: Cannot read property 'name' of null
    at checkForViolation (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:34:39)
    at CatchClause (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/rules/no-shadow-restricted-names.js:65:17)
    at listeners.(anonymous function).forEach.listener (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach ()
    at Object.emit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
    at Traverser.enter [as _enter] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:865:28)

@nignanthomas nignanthomas temporarily deployed to caret-bn-bac-ch-live-no-nxwgr3 January 14, 2020 15:01 Inactive
@ceelogre ceelogre merged commit 7ae0649 into develop Jan 14, 2020
@ceelogre ceelogre deleted the ch-live-notifications-170672722 branch January 14, 2020 15:09
nignanthomas pushed a commit that referenced this pull request Jan 15, 2020
@ceelogre @nignanthomas
Merge pull request #84 from andela/ch-live-notifications-170672722
4fb3518 
#170672722 - Live Notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound left review comments

@ngireric123 ngireric123 ngireric123 approved these changes

@alainmateso alainmateso alainmateso approved these changes

@sabin18 sabin18 Awaiting requested review from sabin18

Assignees

@nignanthomas nignanthomas

Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nignanthomas @ngireric123 @alainmateso @ceelogre