Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CH: Make error human readable #86

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CH: Make error human readable #86

wants to merge 1 commit into from

Conversation

Cheza-Dzabala
Copy link
Contributor

What does this PR do?

  • Updates request validation to create human-readable errors.

Description of Task to be completed?

  • Return human-readable error messages

How should this be manually tested?

  • Clone this repo.
  • run npm install
  • run npm run dev
  • Use postman and attempt to make an invalid request

Any background context you want to provide?

  • Errors were returned in a non human-readable format.

What are the relevant pivotal tracker stories?

#170697260

Screenshots (if appropriate)

Questions:

@Cheza-Dzabala
CH: Make error human readable
223f5a0 
- Updated validateRequest to make error human readable

[finishes #170697260]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngireric123 ngireric123 ngireric123 approved these changes

@alainmateso alainmateso alainmateso approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Cheza-Dzabala @ngireric123 @alainmateso