bug(tags): search by tags

andela · Nov 14, 2019 · 12b213e · 12b213e
1 parent 16e8bec
commit 12b213e
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 32 deletions.
diff --git a/src/controllers/search.controller.js b/src/controllers/search.controller.js
@@ -65,12 +65,18 @@ class Search {
         }
       })
     );
+    const users = await UserModel.searchUser(searchQuery.user, offset, limit);
+    const foundUsers = _.map(
+      users,
+      _.partialRight(_.pick, ["username", "image", "bio"])
+    );
     let duplicateFoundTags = [];
-    foundArticles.map(article => {
+    const allArticles = await ArticleModel.getAllArticles();
+    allArticles.map(article => {
       const articleTags = article.taglist;
-      const found = articleTags.filter(
-        articleTag => articleTag === searchQuery.tag
-      );
+      const found = articleTags
+        ? articleTags.filter(articleTag => articleTag === searchQuery.tag)
+        : [];
       if (found.length >= 1) {
         for (let i = 0; i <= found.length - 1; i++) {
           duplicateFoundTags = [found[i], ...duplicateFoundTags];
@@ -84,11 +90,7 @@ class Search {
     if (foundTags[0] === "") {
       foundTags = [];
     }
-    const users = await UserModel.searchUser(searchQuery.user, offset, limit);
-    const foundUsers = _.map(
-      users,
-      _.partialRight(_.pick, ["username", "image", "bio"])
-    );
+
     util.setSuccess(200, "Search successful", {
       foundArticles,
       foundUsers,

diff --git a/src/seeders/20190820133339-demo-article-2.js b/src/seeders/20190820133339-demo-article-2.js