rating(refactor) add testing for rating and its pagination

[Finishes #167313406]
andela · Aug 29, 2019 · b7c1fce · b7c1fce
1 parent fe0cfec
commit b7c1fce
Show file tree

Hide file tree

Showing 6 changed files with 263 additions and 125 deletions.
diff --git a/src/controllers/rating.controller.js b/src/controllers/rating.controller.js
@@ -104,7 +104,7 @@ class rateController {
         where: { articleSlug }
       });
       if (count === 0) {
-        util.setError(404, `Rating for article with slug ${articleSlug} not found`);
+        util.setError(404, `Article with slug ${articleSlug} not yet Rated`);
         return util.send(res);
       }
       const rating = await RateService.getArticleRatingStatistic(articleSlug);

diff --git a/src/middlewares/rate.middleware.js b/src/middlewares/rate.middleware.js
@@ -7,7 +7,6 @@ export default async (req, res, next) => {
   try {
     const ArticleSlug = req.params.articleSlug;
     const post = await models.Article.findOne({ where: { slug: ArticleSlug } });
-
     if (!post) {
       util.setError(404, 'post not found');
       return util.send(res);

diff --git a/src/routes/api/rate/rate.route.js b/src/routes/api/rate/rate.route.js
@@ -4,10 +4,12 @@ import confirmEmaiAuth from '../../../middlewares/emailVarification.middleware';
 import rateController from '../../../controllers/rating.controller';
 import sanitizeRate from '../../../middlewares/validators/rate.validation';
 import { checkQuery } from '../../../middlewares/query.check';
+import rateMiddleware from '../../../middlewares/rate.middleware';
+import admin from '../../../middlewares/admin';
 
 const router = express.Router();
-router.get('/', checkQuery, rateController.getAllRating);
+router.get('/', [validateToken, confirmEmaiAuth, checkQuery, admin], rateController.getAllRating);
 router.get('/:articleSlug', checkQuery, [validateToken, confirmEmaiAuth], rateController.getArticleRating);
-router.put('/:articleSlug', [validateToken, sanitizeRate, confirmEmaiAuth], rateController.createOrUpdateRate);
+router.put('/:articleSlug', [validateToken, sanitizeRate, confirmEmaiAuth, rateMiddleware], rateController.createOrUpdateRate);
 
 export default router;
diff --git a/src/routes/api/reports/reports.routes.js b/src/routes/api/reports/reports.routes.js
@@ -14,9 +14,9 @@ const router = express.Router();
 // routes for reporting artiles
 router.post('/:Article', [auth, confirmEmailAuth, reportValidator, reportMiddleware], reportController.reportArticle);
 router.delete('/:reportId', [auth, confirmEmailAuth], reportController.deleteReport);
-router.get('/', [auth, confirmEmailAuth], reportController.getMyReport);
+router.get('/', [auth, confirmEmailAuth, checkQuery], reportController.getMyReport);
 router.get('/all', [auth, confirmEmailAuth, admin, checkQuery], reportController.getAllReport);
-router.get('/:Article', [auth, confirmEmailAuth, admin], reportController.getReportsForArticle);
+router.get('/:Article', [auth, confirmEmailAuth, admin, checkQuery], reportController.getReportsForArticle);
 
 
 export default router;