reporting(testing) add testing for reporting article endpoint

[Contimue #167313418]
andela · Aug 27, 2019 · c99ccf0 · c99ccf0
1 parent 9e84226
commit c99ccf0
Show file tree

Hide file tree

Showing 5 changed files with 350 additions and 32 deletions.
diff --git a/src/controllers/report.comtroller.js b/src/controllers/report.comtroller.js
@@ -24,14 +24,17 @@ class Report {
    */
   static async getAllReport(req, res) {
     const counter = await db.count();
-    const { offset, limit } = paginate(req.param.page, req.param.limit, counter);
-
-    const reports = await reportService.getAllReport(offset, limit);
-    if (!reports) {
+    if (counter === 0) {
       util.setError(200, 'No reports found');
       return util.send(res);
     }
-    util.setSuccess(200, 'Reports retrieved successfully', reports);
+    const { offset, limit } = paginate(req.param.page, req.param.limit, counter);
+    const reports = await reportService.getAllReport(offset, limit);
+    const response = {
+      count: counter,
+      reports,
+    };
+    util.setSuccess(200, 'Reports retrieved successfully', response);
     return util.send(res);
   }
 
@@ -45,16 +48,25 @@ class Report {
    * @memberof Report
    */
   static async getMyReport(req, res) {
-    const counter = await db.count({ where: { userId: req.auth.id } });
-    const { offset, limit } = paginate(req.param.page, req.param.limit, counter);
+    try {
+      const counter = await db.count({ where: { userId: req.auth.id } });
+      if (counter === 0) {
+        util.setError(200, 'No reports found');
+        return util.send(res);
+      }
+      const { offset, limit } = paginate(req.param.page, req.param.limit, counter);
 
-    const reports = await reportService.getMyReport(offset, limit, req.auth.id);
-    if (!reports) {
-      util.setError(200, 'No reports found');
+      const reports = await reportService.getMyReport(offset, limit, req.auth.id);
+      const response = {
+        count: counter,
+        yourReport: reports,
+      };
+      util.setSuccess(200, 'Your reports retrieved successfully', response);
+      return util.send(res);
+    } catch (error) {
+      util.setError(500, 'server error contact admin');
       return util.send(res);
     }
-    util.setSuccess(200, 'Your reports retrieved successfully', reports);
-    return util.send(res);
   }
 
   /**
@@ -67,16 +79,25 @@ class Report {
    * @memberof Report
    */
   static async getReportsForArticle(req, res) {
-    const counter = await db.count({ where: { articleSlug: req.params.Article } });
-    const { offset, limit } = paginate(req.param.page, req.param.limit, counter);
-    const articleSlug = req.params.Article;
-    const reports = await reportService.getAllReportForOneArticle(offset, limit, articleSlug);
-    if (!reports) {
-      util.setError(200, 'This article is not yet Reported');
+    try {
+      const counter = await db.count({ where: { articleSlug: req.params.Article } });
+      if (counter === 0) {
+        util.setError(200, 'This article is not yet Reported');
+        return util.send(res);
+      }
+      const { offset, limit } = paginate(req.param.page, req.param.limit, counter);
+      const articleSlug = req.params.Article;
+      const reports = await reportService.getAllReportForOneArticle(offset, limit, articleSlug);
+      const response = {
+        count: counter,
+        reports,
+      };
+      util.setSuccess(200, 'Reports retrieved successfully', response);
+      return util.send(res);
+    } catch (error) {
+      util.setError(500, 'server error contact admin');
       return util.send(res);
     }
-    util.setSuccess(200, 'Reports retrieved successfully', reports);
-    return util.send(res);
   }
 
   /**
@@ -135,7 +156,8 @@ class Report {
       const reportArticle = await reportService.report(report);
       const newReport = {
         reason: reportArticle.reason,
-        ArticleSlug: reportArticle.articleSlug,
+        articleSlug: reportArticle.articleSlug,
+        id: reportArticle.id
       };
       util.setSuccess(200, 'Article Successfully reported', newReport);
       return util.send(res);

diff --git a/src/middlewares/likes.middleware.js b/src/middlewares/likes.middleware.js
@@ -6,10 +6,6 @@ const util = new Util();
 export default async (req, res, next) => {
   try {
     const user = await models.user.findOne({ where: { email: req.auth.email } });
-    if (!user) {
-      util.setError(404, 'you are anonimous');
-      return util.send(res);
-    }
     const userId = user.id;
     const ArticleSlug = req.params.Article;
     const post = await models.Article.findOne({ where: { slug: ArticleSlug } });

diff --git a/src/middlewares/report.middleware.js b/src/middlewares/report.middleware.js
@@ -13,10 +13,6 @@ export default async (req, res, next) => {
       return util.send(res);
     }
     const user = await models.user.findOne({ where: { email: req.auth.email } });
-    if (!user) {
-      util.setError(404, 'you are anonimous');
-      return util.send(res);
-    }
     const userId = user.id;
     if (userId === post.authorId) {
       util.setError(403, 'Sorry you can not report your article.');

diff --git a/src/services/report.service.js b/src/services/report.service.js
@@ -37,7 +37,7 @@ class ReportService {
     try {
       return await db.findAll({
         attributes: {
-          exclude: ['id', 'updatedAt']
+          exclude: ['updatedAt']
         },
         // include: [{ model: users, username }],
         order: [
@@ -66,7 +66,7 @@ class ReportService {
       return await db.findAll({
         where: { articleSlug },
         attributes: {
-          exclude: ['id', 'updatedAt']
+          exclude: ['updatedAt']
         },
         // include: [{ model: users, username }],
         order: [
@@ -95,7 +95,7 @@ class ReportService {
       return await db.findAll({
         where: { userId },
         attributes: {
-          exclude: ['id', 'updatedAt', 'userId']
+          exclude: ['updatedAt', 'userId']
         },
         order: [
           ['createdAt', 'DESC']