#168256011 Refactor code to improve the maintainability #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkalyesubula
requested review from
Mnickii,
minega25,
Anguandia,
habinezadalvan,
nshutijonathan and
salviosage
Mnickii
suggested changes
Sep 9, 2019
| router.get('/profiles/followers', validateToken, followController.listOfFollowers); | ||
| // router.get('/profiles/following', validateToken, followController.listOfFollowedUsers); | ||
| // router.get('/profiles/followers', validateToken, followController.listOfFollowers); | ||
| router.get('/profiles/:followersOrFollowing', validateToken, followController.listOfFollowersOrFollowed); |
There was a problem hiding this comment.
The previous way was better in the case of routing because the 2 routes are different and therefore should have different methods.
There was a problem hiding this comment.
In terms of conventions too. e.g look at twitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
#168256011
Screenshots (if appropriate)