Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#169258514: Heroku database bug fix #67

Merged
merged 1 commit into from
Oct 21, 2019
Merged

#169258514: Heroku database bug fix #67

merged 1 commit into from
Oct 21, 2019

Conversation

habinezadalvan
Copy link
Contributor

What does this PR do?

  • Fixes the issue of heroku that empties the database.

Description of Task to be completed?

  • Modifies the start script in the package.json

How should this be manually tested?

  • clone the repo
  • run git checkout bg-heroku-database-bug-fix-169258514
  • run npm start

Any background context you want to provide?

  • none

What are the relevant pivotal tracker stories?

#169258514

Screenshots (if appropriate)

Before modification
Screen Shot 2019-10-21 at 13 17 39

After modification

Screen Shot 2019-10-21 at 13 18 39

Questions:

none

@salviosage salviosage temporarily deployed to codepirates-ah-backend-staging October 21, 2019 11:30 Inactive
nshutijonathan
nshutijonathan reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@nshutijonathan nshutijonathan left a comment •
edited by habinezadalvan
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What confirms if our app is working on Heroku? how is admin going to be created since you deleted npm run seeds
Don't worry about seeds, they are already on heroku.

minega25
minega25 previously approved these changes Oct 21, 2019
View reviewed changes
nshutijonathan
nshutijonathan previously approved these changes Oct 21, 2019
View reviewed changes
salviosage
salviosage previously approved these changes Oct 21, 2019
View reviewed changes
Copy link
Collaborator

@salviosage salviosage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@habinezadalvan habinezadalvan force-pushed the bg-heroku-database-bug-fix-169258514 branch from 8922d37 to 594b968 Compare October 21, 2019 13:08
@salviosage salviosage self-requested a review October 21, 2019 13:14
salviosage
salviosage approved these changes Oct 21, 2019
View reviewed changes
Copy link
Collaborator

@salviosage salviosage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minega25 minega25 self-requested a review October 21, 2019 13:15
@salviosage salviosage merged commit 8b49ab5 into develop Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minega25 minega25 minega25 approved these changes

@salviosage salviosage salviosage approved these changes

@nkalyesubula nkalyesubula nkalyesubula approved these changes

@nshutijonathan nshutijonathan nshutijonathan left review comments

@Anguandia Anguandia Awaiting requested review from Anguandia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@habinezadalvan @nshutijonathan @minega25 @salviosage @nkalyesubula