Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share front, insteat of back end link #74

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Anguandia
Copy link
Contributor

What does this PR do?

Share the front end link to an article as opposed to sharing the back end link

Description of Task to be completed?

  • Pass the link to share in the body of the share request

How should this be manually tested?

  • Run this backend
  • On postman, make a post request to http://localhost:<your port>/api/v1/articles/<valid article slug>/share/<[mail, facebook or twitter>
  • Copy any webpage URL and supply it as the url property value in the request body
  • Ensure you have a valid token
  • Expect a browser window to open for interactive completion of the sharing
  • After completing the sharing dialogue, open whichever forum you shared to and click on the received link
  • You should see exactly the same page you shared

Any background context you want to provide?

The previous implementation shared the backend link to the article that returned the raw resource from the database, not readable, especially images

What are the relevant pivotal tracker stories?

Fixes #169619406

Screenshots (if appropriate)

Questions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant