Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#169643311 Users should be able to get notifications #76

Merged
merged 3 commits into from
Nov 11, 2019

Conversation

nkalyesubula
Copy link
Contributor

@nkalyesubula nkalyesubula commented Nov 8, 2019

  • What does this PR do?

  • Adds functionality for getting user notifications

Description of Task to be completed?

  • Given a user opted-in for notifications, he should be able to receive them every time a person he follows publishes a new article or when an article he favorited receives new reactions e.g comments

How should this be manually tested?

  • clone repo, and then run npm run dev in your terminal

  • Go to the postman and run this route :localhost:8080/api/v1/notifications

What are the relevant pivotal tracker stories?

#169643311

Screenshots (if appropriate)

image
image

image
image

fix missing images ptoperty bug in article update
Copy link
Collaborator

@salviosage salviosage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, I have left some comment.

src/controllers/notifications.controller.js Show resolved Hide resolved
src/controllers/notifications.controller.js Show resolved Hide resolved
@nkalyesubula nkalyesubula force-pushed the ft-user-get-notifications-169643311 branch from d950440 to 0627793 Compare November 11, 2019 07:42
Copy link
Contributor

@minega25 minega25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salviosage salviosage self-requested a review November 11, 2019 08:56
Copy link
Collaborator

@salviosage salviosage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salviosage salviosage merged commit 199c9d5 into develop Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants