Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#169654249 bug fix tagging issue on creating articles #77

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

nshutijonathan
Copy link
Contributor

What does this PR do?

-It adds tagging functionality

Description of Task to be completed?

  • Added field of tags in the articles table

How should this be manually tested?

  • clone the repo the

Any background context you want to provide?

  • Download or clone the tutorial project code from here, in your terminal then git checkout bg-fix-user-tag-on-creating-article-169654249 , install all required NPM packages by running NPM install from the command line in the project root folder (where the package.json is located).

  • Start the API by running NPM start from the command line in the project root folder, you should see the message Server listening on port 8000. You can test the API directly using an application such as Postman or you can test it with one of the single pages in the browser.

  • to test authentication and authorization, add this to the header
    Key: :x-access-token,value:JWT TOKEN

What are the relevant pivotal tracker stories?

https://www.pivotaltracker.com/story/show/169654249

Screenshots (if appropriate)

image

Questions:

Copy link
Collaborator

@salviosage salviosage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @nshutijonathan , nice work. I have left some comment

src/controllers/articles.controller.js Show resolved Hide resolved
@nshutijonathan nshutijonathan force-pushed the bg-fix-user-tag-on-creating-article-169654249 branch from 2368683 to 1faf615 Compare November 11, 2019 09:56
@nshutijonathan nshutijonathan force-pushed the bg-fix-user-tag-on-creating-article-169654249 branch from 1faf615 to 5085875 Compare November 11, 2019 12:27
@salviosage salviosage merged commit 9cfe092 into develop Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants