#167484603 Fetch all available profiles #19
Conversation
This allows an authenticated user to fetch other users profiles [Finishes #167484603]
malaba6
requested review from
mkiterian,
Jkadhuwa,
placideirandora,
harerakalex and
raymond42
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
On it. This happened because of the merging. Let me rebase and get rid of the conflict |
This allows an authenticated user to fetch other users profiles [Finishes #167484603]
This allows an authenticated user to fetch all available profiles [Delivers #167484603]
src/controllers/profileController.js
Outdated
| data: users | ||
| }); | ||
| } catch (err) { | ||
| // console.log(err); |
There was a problem hiding this comment.
do not mute the error. I'd rather you throw the error, this is important for debugging purposes
src/tests/userprofile.test.js
Outdated
| }); | ||
|
|
||
| describe('GET /api/v1/profiles', () => { | ||
| it('Should A list of profiles if user is identified', (done) => { |
There was a problem hiding this comment.
grammar: "Should return a list ..."
src/tests/userprofile.test.js
Outdated
| }); | ||
| }); | ||
|
|
||
| describe('GET /api/v1/profiles', () => { |
There was a problem hiding this comment.
this looks like a copy of https://github.com/andela/coding-geeks-ah-backend/pull/19/files#diff-7e80fd915c1e3097f4adf33a8a3c7f0dR60
There was a problem hiding this comment.
I'd also like to see an assertion about the number of profiles returned is what we expect
There was a problem hiding this comment.
this looks like a copy of https://github.com/andela/coding-geeks-ah-backend/pull/19/files#diff-7e80fd915c1e3097f4adf33a8a3c7f0dR60
Ok...fixed
There was a problem hiding this comment.
I'd also like to see an assertion about the number of profiles returned is what we expect
On it...
I authenticated this endpoint because it is required according to the story description on the PT board here for |
What does this PR do?
user can successfully login testDescription of Task to be completed?
fetchProfilesinside the classProfilein theprofileControllerfile.routesfolder to fetch profiles with thegetmethoduserProfile.testfile, add tests for this endpointswagger.jsonfile, add/api/v1/profilesin the swagger file's path to document this endpointHow should this be manually tested?
In Postman or Swagger or any other tool of your choice visit this enpoint:
/api/v1/profilesto fetch a list of profilesAny background context you want to provide:
To access this endpoint, User must be authenticated. And use the token generated for Loggin or Registration as
Authorisationin the 'header'.What are the relevant pivotal tracker stories?
List user functionality
Screenshots?
In Postman
In swagger
