#167966138 Enable user to update and delete articles #27

Jkadhuwa · 2019-08-21T15:08:59Z

What does this PR do?

Enables user to update, delete and get single article

How should this be manually tested?

git fetch
git checkout ft-user-update-delete-articles-167966138
npm install
npm run dev

Using postman test using the following endpoints

 put /api/v1/articles/:slug
   - and supply the fields you want to update

delete /api/v1/articles/:slug 
   - to delete specified article

get /api/v1/articles/:slug 
   - to get the specified article

What are the relevant pivotal tracker stories?

Update or Delete Articles

Screenshots

hound · 2019-08-21T15:09:08Z

src/sequelize/seeders/20190820163908-create-admin-and-user.js

@@ -0,0 +1,22 @@
+import bcrypt from 'bcrypt';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-08-21T15:09:09Z

src/middleware/findOwner.js

@@ -0,0 +1,24 @@
+import { Article } from '../sequelize/models';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

malaba6 · 2019-08-22T01:55:56Z

swagger.json

+                        }
+                    }
+                },
+                "404": {


In the responses status code, I don't see 403 whereby the user is not allowed to delete an article that does not belong to them for example.

harerakalex · 2019-08-22T04:55:29Z

src/controllers/articleController.js

+  static async deteleArticle(req, res) {
+    try {
+      const deleted = await Article.destroy({
+        where: { slug: req.userData.slug }


Why did you use slug instead of ID to delete article?

We already had slug from the params, I thought it would be efficient to delete using it rather than going to the DB search for an article using slug so as to get the id. But I have got another way of getting the id which I have implemented it.

mkiterian · 2019-08-22T09:37:49Z

src/controllers/articleController.js

+      }
+      article.description = (description || originalArticle.description).trim();
+      article.body = (body || originalArticle.body).trim();
+      article.tagList = (tags || originalArticle.tagList.toString()).trim().split(/[ ,]+/);


trying to update an article that didn't have previous tags throws TypeError: Cannot read property 'toString' of null

Thanks, I found that also and fixed it. I will be pushing the changes in a min.

mkiterian · 2019-08-22T09:41:00Z

src/controllers/articleController.js

+      article.description = (description || originalArticle.description).trim();
+      article.body = (body || originalArticle.body).trim();
+      article.tagList = (tags || originalArticle.tagList.toString()).trim().split(/[ ,]+/);
+      article.category = (category || originalArticle.category).trim();


why trim originalArticle.category?

Here I am checking for the category from req.body to trim but when I define (category.trim() || originalArticle.category) throws an error when the category is undefined

mkiterian · 2019-08-22T09:47:46Z

src/controllers/articleController.js

+        article.title = title.trim();
+        article.slug = slugGen(title.trim());
+      }
+      article.description = (description || originalArticle.description).trim();


article.description = description.trim() || originalArticle.description;

I also see that trim has been added to the validation rules, is there a reason we have it here as well?

If the description is undefined it throws an error "can not trim value of undefined"

I also see that trim has been added to the validation rules, is there a reason we have it here as well?

In the validations am checking for empty fields but in the controller am trimming white spaces before or after a string.

article.description = description ? description.trim() : originalArticle.description;

mkiterian · 2019-08-22T09:48:26Z

src/controllers/articleController.js

+      );
+      if (updatedArticle) {
+        return res.status(200).json({
+          message: 'Profile updated successfully',


Article updated successfully

I am changing that.

mkiterian · 2019-08-22T09:51:22Z

src/controllers/articleController.js

+        article.title = title.trim();
+        article.slug = slugGen(title.trim());
+      }
+      article.description = (description || originalArticle.description).trim();


I also see that trim has been added to the validation rules, is there a reason we have it here as well?

…rticles [Start #167966138]

mkiterian · 2019-08-22T19:11:32Z

src/controllers/articleController.js

+        article.title = title.trim();
+        article.slug = slugGen(title.trim());
+      }
+      article.description = (description || originalArticle.description).trim();


article.description = description ? description.trim() : originalArticle.description;

…66138]

…ah-backend into ft-user-update-and-delete-articles-167966138

Jkadhuwa added the Need Reviews Feedback to PR raised label Aug 21, 2019

Jkadhuwa requested review from mkiterian, placideirandora, harerakalex, raymond42 and malaba6 August 21, 2019 15:08

hound bot reviewed Aug 21, 2019

View reviewed changes

Jkadhuwa force-pushed the ft-user-update-and-delete-articles-167966138 branch from e144bba to 429b0ca Compare August 21, 2019 17:59

malaba6 suggested changes Aug 22, 2019

View reviewed changes

harerakalex reviewed Aug 22, 2019

View reviewed changes

mkiterian suggested changes Aug 22, 2019

View reviewed changes

mkiterian reviewed Aug 22, 2019

View reviewed changes

mkiterian suggested changes Aug 22, 2019

View reviewed changes

Jkadhuwa force-pushed the ft-user-update-and-delete-articles-167966138 branch from d9c177e to ffe884d Compare August 22, 2019 18:31

feature(Update and Delete articles): adds files to update or delete a…

85310d4

…rticles [Start #167966138]

Jkadhuwa force-pushed the ft-user-update-and-delete-articles-167966138 branch from ffe884d to 8fda042 Compare August 22, 2019 18:42

mkiterian suggested changes Aug 22, 2019

View reviewed changes

feature(Update and Delete articles): implements feedback [Fixes #1679…

0d7d7d9

…66138]

Jkadhuwa force-pushed the ft-user-update-and-delete-articles-167966138 branch from 8fda042 to 0d7d7d9 Compare August 22, 2019 19:37

raymond42 temporarily deployed to codinggeeks-ah-backnd-st-pr-27 August 23, 2019 08:18 Inactive

raymond42 added finished and removed Need Reviews Feedback to PR raised labels Aug 23, 2019

Merge branch 'development' of https://github.com/andela/coding-geeks-…

1c657fb

…ah-backend into ft-user-update-and-delete-articles-167966138

Jkadhuwa force-pushed the ft-user-update-and-delete-articles-167966138 branch from 035cf4a to 1c657fb Compare August 23, 2019 11:09

raymond42 deployed to codinggeeks-ah-backnd-st-pr-27 August 23, 2019 11:09 View deployment

raymond42 added Need Reviews Feedback to PR raised and removed finished labels Aug 23, 2019

mkiterian merged commit 3e22c8f into development Aug 23, 2019

Jkadhuwa removed the Need Reviews Feedback to PR raised label Aug 24, 2019

Jkadhuwa added the finished label Aug 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#167966138 Enable user to update and delete articles #27

#167966138 Enable user to update and delete articles #27

Jkadhuwa commented Aug 21, 2019 •

edited

Loading

hound bot Aug 21, 2019

hound bot Aug 21, 2019

malaba6 Aug 22, 2019

Jkadhuwa Aug 22, 2019

harerakalex Aug 22, 2019

Jkadhuwa Aug 22, 2019

mkiterian Aug 22, 2019

Jkadhuwa Aug 22, 2019

mkiterian Aug 22, 2019

Jkadhuwa Aug 22, 2019

mkiterian Aug 22, 2019

mkiterian Aug 22, 2019

Jkadhuwa Aug 22, 2019

Jkadhuwa Aug 22, 2019

mkiterian Aug 22, 2019

mkiterian Aug 22, 2019

Jkadhuwa Aug 22, 2019

mkiterian Aug 22, 2019

mkiterian Aug 22, 2019

		@@ -0,0 +1,24 @@
		import { Article } from '../sequelize/models';

#167966138 Enable user to update and delete articles #27

#167966138 Enable user to update and delete articles #27

Conversation

Jkadhuwa commented Aug 21, 2019 • edited Loading

What does this PR do?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Screenshots

hound bot Aug 21, 2019

Choose a reason for hiding this comment

hound bot Aug 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jkadhuwa commented Aug 21, 2019 •

edited

Loading