Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167733813 Set up sign-in endpoint #21

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Conversation

Ileriayo
Copy link
Collaborator

What does this PR do?

  • It sets up the endpoint to allow a user log into the app

Description of Task to be completed?

  • Write unit tests for the login endpoint
  • Write login controller logic to pass the test cases
  • Ensure that test coverage does not drop
  • Document the endpoint using Swagger

How should this be manually tested?

  • On Postman send a POST request to /api/v1/auth/signin with email and password as parameters

Any background context you want to provide?

  • N/A

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

postman_login
swagger-login

@fegzycole
Copy link
Collaborator

This is good to go

@tamunoibi
Copy link
Collaborator

Looks good. Great job.

Copy link
Collaborator

@fegzycole fegzycole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

@Oluwafayokemi Oluwafayokemi merged commit 06da9d5 into develop Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants