Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#167733835 Implement search functionality #57

Merged
merged 4 commits into from
Sep 16, 2019
Merged

#167733835 Implement search functionality #57

merged 4 commits into from
Sep 16, 2019

Conversation

Ileriayo
Copy link
Collaborator

What does this PR do?

  • It implements search functionality for the application

Description of Task to be completed?

  • Create a route /api/v1/request/search?<query>
  • Write test for the search functionality
  • Write controller logic for the search functionality
  • Document the search functionality

How should this be manually tested?

  • On Postman send a GET request to /api/v1/request/search?<query>
    e.g., /api/v1/request/search?type=one-way&status=approved

Any background context you want to provide?

  • N/A

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

@Ileriayo Ileriayo added the work in progress Not ready for merge work is still on going label Sep 13, 2019
@Ileriayo Ileriayo added ready for merge Good waiting for review Extra attention is needed and removed work in progress Not ready for merge work is still on going labels Sep 15, 2019
@Ileriayo Ileriayo removed the waiting for review Extra attention is needed label Sep 15, 2019
EziamakaNV
EziamakaNV approved these changes Sep 15, 2019
View reviewed changes
Copy link
Collaborator

@EziamakaNV EziamakaNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice One!

@Ileriayo Ileriayo removed the request for review from fegzycole September 16, 2019 09:00
@Oluwafayokemi Oluwafayokemi merged commit 17cf3d8 into develop Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamunoibi tamunoibi tamunoibi approved these changes

@Oluwafayokemi Oluwafayokemi Oluwafayokemi approved these changes

@EziamakaNV EziamakaNV EziamakaNV approved these changes

@codecell codecell codecell approved these changes

Assignees
No one assigned
Labels
ready for merge Good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ileriayo @tamunoibi @Oluwafayokemi @EziamakaNV @codecell