Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

164796895 like article functionality #56

Merged
merged 5 commits into from
Apr 15, 2019

Conversation

ssanusi
Copy link
Contributor

@ssanusi ssanusi commented Apr 12, 2019

Description

The Pull Request add the feature of liking article to the app

Type of change

  • added functionality to like and unlike the article

How Has This Been Tested?

  • after login at /api/v1/log copy token to the header
  • send a patch request /api/v1/articles/:articleid/like you will be required to log in to the application

Checklist:

  • User can Like Article
  • Integration Testing

PT

#164796895

src/routers/index.js Outdated Show resolved Hide resolved
@ssanusi ssanusi added WIP This is still being worked on and removed WIP This is still being worked on labels Apr 12, 2019
src/controllers/like.js Outdated Show resolved Hide resolved
src/routers/index.js Show resolved Hide resolved
tests/integration/like.test.js Outdated Show resolved Hide resolved
@ssanusi ssanusi force-pushed the feature/164796895-like-article-functionality branch from b5e26ff to f071e1a Compare April 13, 2019 17:05
Copy link
Contributor

@Simplemart17 Simplemart17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-done @ssanusi For consistency, you might want to consider changing the block of code in the like controllers to async/await and using try-catch block. Thank you.

@ssanusi ssanusi force-pushed the feature/164796895-like-article-functionality branch from b8c24fa to 8ef3ff9 Compare April 14, 2019 06:08
-Implement Model for Like                                                                                                                                               -implement migration for Like table                                                                                                                                     -implemement Route and controller
[delivers  #164892850]
- implement ariticle validation
                                                                                                                                                                                                [delivers  #164892850]
- implement ariticle validation

[delivers  #164892850]"
- refactor passport config
                                                                                                                                                                   [delivers  #164892850]
-refactor

[Delivers #164796895]
@ssanusi ssanusi force-pushed the feature/164796895-like-article-functionality branch from 8ef3ff9 to a78accd Compare April 15, 2019 10:33
@Temmyogunbo Temmyogunbo merged commit 978f95b into develop Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants