#167164993 add user notification #29

benisi · 2019-08-07T04:04:09Z

Screenshots

response

flow chart

Pivotal tracker story

#167164993

What does this PR do?

Add functions to create user notification

Summary of Task

This PR adds the following to the project

add notification config / template file
add notifications route
add add notification function to add notification
add get notification function to get notification
add email notification functionality

How can this be tested?

# Clone this repository
$ git clone https://github.com/andela/dahlia-ah-backend.git

# Navigate to the application folder
$ cd dahlia-ah-backend

# Install dependencies
$ npm install

# start the server by typing
$ npm run dev:start

# send a get request to http://localhost:3000/api/v1/notifications 
make sure you enter you authorization header token

you will get the notification of the user that are unread if there is none you will receive an empty array.

allebd

I observed no screenshot attached

.

Ukhu · 2019-08-17T11:07:10Z

Kindly place your screenshot as the last section of the PR description as stated in the template, and add a screenshot of your flowchart for this task.

benisi · 2019-08-18T11:31:21Z

Kindly place your screenshot as the last section of the PR description as stated in the template, and add a screenshot of your flowchart for this task.

i am having a problem loading screenshot on the bottom, it seems to only show at the top

allebd · 2019-08-18T22:32:08Z

docs/swagger.yaml

@@ -14,7 +14,7 @@ externalDocs:
  url: https://github.com/andela/dahlia-ah-backend

 servers:
- url: /api/v1
+- url: http://localhost:3000


I observed you specified port 3000 above if another person is not using the same port number do you think it will still work.

OvieMudi

LGTM

Nerocodes

LGTM

Ukhu · 2019-08-19T12:05:04Z

src/controllers/NotificationController.js

+
+const getNotification = async (req, res) => {
+  const { id } = req.user;
+  const userNotificationObject = await getUserNotification(id);


I feel you could use a try/catch block in this controller, in case an error occurs while awaiting getUserNotification(id)

Pls attend to this review

profmcdan

Attend to the feedback, as well as handle necessary errors in your code

profmcdan · 2019-08-22T09:11:21Z

src/controllers/NotificationController.js

+
+const getNotification = async (req, res) => {
+  const { id } = req.user;
+  const userNotificationObject = await getUserNotification(id);


Pls attend to this review

profmcdan · 2019-08-22T09:19:12Z

src/helpers/emailMessages.js

+    subject: 'Authors Haven - Notification',
+    html: `${messageHeader}
+            <p>${actor} ${message}
+            <a href='${process.env.SERVER_URL}${novelUrl || ''}'> ${novelTitle || ''}</a></p>


Please consider a better implementation here

- add in app notification using socket.io - add email notification - add get all notification [Finishes #167164993]

Nerocodes temporarily deployed to ah-dahlia-staging-pr-29 August 7, 2019 04:04 Inactive

benisi requested review from Nerocodes, Ukhu, OvieMudi, allebd, Rythae and WilliamsOhworuka August 7, 2019 04:05

benisi added the WIP - Work In Progress label Aug 7, 2019

benisi force-pushed the feature/167164993/create-notification branch from 8ae5054 to c0346ed Compare August 7, 2019 10:56

Nerocodes temporarily deployed to ah-dahlia-staging-pr-29 August 7, 2019 10:57 Inactive

benisi removed the WIP - Work In Progress label Aug 7, 2019

benisi force-pushed the feature/167164993/create-notification branch from c0346ed to e0c96f9 Compare August 14, 2019 07:53

Nerocodes had a problem deploying to ah-dahlia-staging-pr-29 August 14, 2019 07:53 Failure

benisi changed the title ~~feature(notification) add user notification~~ #167164993 add user notification Aug 14, 2019

benisi force-pushed the feature/167164993/create-notification branch from e0c96f9 to 73ca266 Compare August 14, 2019 12:21

Nerocodes had a problem deploying to ah-dahlia-staging-pr-29 August 14, 2019 12:21 Failure

allebd reviewed Aug 15, 2019

View reviewed changes

WilliamsOhworuka previously approved these changes Aug 16, 2019

View reviewed changes

benisi force-pushed the feature/167164993/create-notification branch from 73ca266 to 06b50a2 Compare August 16, 2019 21:33

Nerocodes had a problem deploying to ah-dahlia-staging-pr-29 August 16, 2019 21:34 Failure

benisi force-pushed the feature/167164993/create-notification branch from 06b50a2 to debf3a4 Compare August 16, 2019 22:30

Nerocodes had a problem deploying to ah-dahlia-staging-pr-29 August 16, 2019 22:31 Failure

benisi force-pushed the feature/167164993/create-notification branch from debf3a4 to 8e9fc70 Compare August 17, 2019 02:29

Nerocodes had a problem deploying to ah-dahlia-staging-pr-29 August 17, 2019 02:29 Failure

benisi force-pushed the feature/167164993/create-notification branch from 8e9fc70 to 02cfb9b Compare August 17, 2019 02:36

Nerocodes had a problem deploying to ah-dahlia-staging-pr-29 August 17, 2019 02:37 Failure

benisi force-pushed the feature/167164993/create-notification branch from 02cfb9b to c7c7483 Compare August 17, 2019 03:22

Nerocodes had a problem deploying to ah-dahlia-staging-pr-29 August 17, 2019 03:22 Failure

allebd reviewed Aug 18, 2019

View reviewed changes

benisi force-pushed the feature/167164993/create-notification branch from c7c7483 to 23a1ec2 Compare August 19, 2019 07:37

Nerocodes had a problem deploying to ah-dahlia-staging-pr-29 August 19, 2019 07:37 Failure

WilliamsOhworuka approved these changes Aug 19, 2019

View reviewed changes

OvieMudi approved these changes Aug 19, 2019

View reviewed changes

Nerocodes approved these changes Aug 19, 2019

View reviewed changes

Ukhu reviewed Aug 19, 2019

View reviewed changes

profmcdan suggested changes Aug 22, 2019

View reviewed changes

benisi force-pushed the feature/167164993/create-notification branch from 23a1ec2 to fd2badc Compare August 22, 2019 14:41

Nerocodes had a problem deploying to ah-dahlia-staging-pr-29 August 22, 2019 14:41 Failure

Nerocodes temporarily deployed to ah-dahlia-staging-pr-29 August 22, 2019 15:22 Inactive

feature(notification) add user notification

c2398a0

- add in app notification using socket.io - add email notification - add get all notification [Finishes #167164993]

benisi force-pushed the feature/167164993/create-notification branch from fd2badc to c2398a0 Compare August 22, 2019 15:50

Nerocodes deployed to ah-dahlia-staging-pr-29 August 22, 2019 15:50 View deployment

profmcdan approved these changes Aug 22, 2019

View reviewed changes

profmcdan merged commit 5e834fe into staging Aug 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#167164993 add user notification #29

#167164993 add user notification #29

benisi commented Aug 7, 2019 •

edited

Loading

allebd left a comment

Ukhu commented Aug 17, 2019

benisi commented Aug 18, 2019

allebd Aug 18, 2019

OvieMudi left a comment

Nerocodes left a comment

Ukhu Aug 19, 2019

profmcdan Aug 22, 2019

benisi Aug 22, 2019

profmcdan left a comment

profmcdan Aug 22, 2019

profmcdan Aug 22, 2019

benisi Aug 22, 2019

#167164993 add user notification #29

#167164993 add user notification #29

Conversation

benisi commented Aug 7, 2019 • edited Loading

Screenshots

Pivotal tracker story

What does this PR do?

Summary of Task

How can this be tested?

allebd left a comment

Choose a reason for hiding this comment

Ukhu commented Aug 17, 2019

benisi commented Aug 18, 2019

allebd Aug 18, 2019

Choose a reason for hiding this comment

OvieMudi left a comment

Choose a reason for hiding this comment

Nerocodes left a comment

Choose a reason for hiding this comment

Ukhu Aug 19, 2019

Choose a reason for hiding this comment

profmcdan Aug 22, 2019

Choose a reason for hiding this comment

benisi Aug 22, 2019

Choose a reason for hiding this comment

profmcdan left a comment

Choose a reason for hiding this comment

profmcdan Aug 22, 2019

Choose a reason for hiding this comment

profmcdan Aug 22, 2019

Choose a reason for hiding this comment

benisi Aug 22, 2019

Choose a reason for hiding this comment

benisi commented Aug 7, 2019 •

edited

Loading