Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167165004 view and add read stats #48

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

OvieMudi
Copy link
Contributor

What does this PR do?

  • adds an endpoint for marking a novel as read
  • add an endpoint for viewing read stats

Description of Task to be completed?

  • Ensure the following endpoints are working

PATCH /api/v1/novels/<slug>/markread
GET /api/v1/profiles/readstats

How should this be manually tested?

To test manually on your local computer:

  • run the following commands.
# Clone this repository
$ git clone https://github.com/andela/dahlia-ah-backend.git

# Navigate to the application folder
$ cd dahlia-ah-backend

# Checkout the branch
$ git checkout feature/167165004/view-reading-stats
# Install dependencies
$ npm install

# Start the app in development mode
$ npm run dev:start
  • check the .env.example file on the environmental variables to provide
  • on Postman make an authorized request to the endpoints above

Note: See the screenshot below on how the request/response should look

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#167165004

Screenshots

Screenshot 2019-08-21 at 10 01 32 AM

Screenshot 2019-08-21 at 9 59 54 AM

API Flowchart

API Flowchart read stats

src/services/novelService.js Outdated Show resolved Hide resolved
src/services/novelService.js Outdated Show resolved Hide resolved
@Nerocodes Nerocodes temporarily deployed to ah-dahlia-staging-pr-48 August 21, 2019 09:10 Inactive
@OvieMudi OvieMudi force-pushed the feature/167165004/view-reading-stats branch from 8caa979 to 52a3f9c Compare August 21, 2019 10:02
@OvieMudi OvieMudi changed the title feature(read stats): view and add read stats #167165004 view and add read stats Aug 22, 2019
@OvieMudi OvieMudi force-pushed the feature/167165004/view-reading-stats branch from 52a3f9c to f94dad1 Compare August 27, 2019 05:52
@Nerocodes Nerocodes had a problem deploying to ah-dahlia-staging-pr-48 August 27, 2019 05:53 Failure
- write unit test for feature
- create endpoint for adding/removing novel as read
- create endpoint for viewing read stats
-  document feature on swagger

[Delivers #167165004]
@OvieMudi OvieMudi force-pushed the feature/167165004/view-reading-stats branch from f94dad1 to 867faae Compare August 27, 2019 05:54
@Nerocodes Nerocodes had a problem deploying to ah-dahlia-staging-pr-48 August 27, 2019 05:54 Failure
src/helpers/validator.js Outdated Show resolved Hide resolved
@Nerocodes Nerocodes had a problem deploying to ah-dahlia-staging-pr-48 August 27, 2019 12:37 Failure
@Nkemjiks Nkemjiks merged commit 9fe7203 into staging Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants