#167164944 View an Edit Author Profile #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamsOhworuka
previously approved these changes
Sep 13, 2019
OvieMudi
force-pushed
the
feature/167164944/user-can-view-profile
branch
from
70b8343
to
7bfe4dc
Compare
- design and create components for viewing profile - add unit testing [Starts #167164944]
OvieMudi
force-pushed
the
feature/167164944/user-can-view-profile
branch
from
7bfe4dc
to
89bb5a7
Compare
OvieMudi
force-pushed
the
feature/167164944/user-can-view-profile
branch
from
89bb5a7
to
64220bb
Compare
OvieMudi
force-pushed
the
feature/167164944/user-can-view-profile
branch
from
2fe1c99
to
4f421e2
Compare
Nkemjiks
suggested changes
Sep 13, 2019
| const { token } = JSON.parse(window.localStorage.getItem('AuthorsHavenUser')) || { token: null }; | ||
| if (token) { | ||
|
|
||
| const user = JSON.parse(window.localStorage.getItem('AuthorsHavenUser')); |
There was a problem hiding this comment.
This is to handle a case where the AuthorsHavenUser is deleted from the local storage when still logged in (i.e not redirected to the landing page). I faced error when that happened.
OvieMudi
changed the title
- handle state updates properly to avoid window reload - add and link "START WRITING"
OvieMudi
added
Needs review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
/profilee.g http://localhost:3000/profile
How should this be manually tested?
To test manually on your local computer with
localhost.env.examplefile on the environmental variables to provideNote: Kindly checkouts the screenshots section the layout to expect
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#167164944
Screenshots