Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

167130331-bug-fix heroku build #20

Merged
merged 1 commit into from
Jul 8, 2019
Merged

167130331-bug-fix heroku build #20

merged 1 commit into from
Jul 8, 2019

Conversation

FrankChinedu
Copy link
Contributor

Description

add fix to let heroku build

Type of change

Please select the relevant option

  • Bug fix (non-breaking changes which fixes an issue)
  • New feature (non-breaking changes which adds functionality)
  • Breaking change (fix or feature that could cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Chore

How Has This Been Tested?

please describe the test that you ran to verify your changes

  • End to end
  • Integration
  • Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have linted my code prior to submission
  • I have made corresponding changes to the documentation
  • My changes generates no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Pivotal Tracker

#167130331

@vincentayorinde vincentayorinde requested a deployment to demeter-ah-backend-stagi-pr-20 July 8, 2019 10:55 Abandoned
@vincentayorinde vincentayorinde temporarily deployed to demeter-ah-backend-stagi-pr-20 July 8, 2019 10:56 Inactive
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from 85c23de to b9c4003 Compare July 8, 2019 11:27
@FrankChinedu FrankChinedu temporarily deployed to demeter-ah-backend-stagi-pr-20 July 8, 2019 11:28 Inactive
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from b9c4003 to bfccf01 Compare July 8, 2019 11:31
@FrankChinedu FrankChinedu temporarily deployed to demeter-ah-backend-stagi-pr-20 July 8, 2019 11:31 Inactive
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from bfccf01 to 9849457 Compare July 8, 2019 11:41
@FrankChinedu FrankChinedu had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 11:42 Failure
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from 9849457 to 9da6aa5 Compare July 8, 2019 11:43
@FrankChinedu FrankChinedu had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 11:43 Failure
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from 9da6aa5 to f6a1b4d Compare July 8, 2019 11:55
@FrankChinedu FrankChinedu had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 11:55 Failure
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from f6a1b4d to 11b60d4 Compare July 8, 2019 11:58
@vincentayorinde vincentayorinde had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 11:59 Failure
@vincentayorinde vincentayorinde had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 12:00 Failure
@vincentayorinde vincentayorinde had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 12:01 Failure
@vincentayorinde vincentayorinde had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 12:11 Failure
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from 11b60d4 to 3253456 Compare July 8, 2019 12:13
@vincentayorinde vincentayorinde had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 12:13 Failure
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from 3253456 to 7062427 Compare July 8, 2019 12:20
@vincentayorinde vincentayorinde temporarily deployed to demeter-ah-backend-stagi-pr-20 July 8, 2019 12:22 Inactive
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from 7062427 to 688d774 Compare July 8, 2019 12:35
@FrankChinedu FrankChinedu temporarily deployed to demeter-ah-backend-stagi-pr-20 July 8, 2019 12:36 Inactive
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from 688d774 to 7b033f7 Compare July 8, 2019 12:54
@FrankChinedu FrankChinedu temporarily deployed to demeter-ah-backend-stagi-pr-20 July 8, 2019 12:55 Inactive
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from 7b033f7 to eea7a37 Compare July 8, 2019 13:04
@FrankChinedu FrankChinedu temporarily deployed to demeter-ah-backend-stagi-pr-20 July 8, 2019 13:05 Inactive
@vincentayorinde vincentayorinde had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 13:11 Failure
@vincentayorinde vincentayorinde had a problem deploying to demeter-ah-backend-stagi-pr-20 July 8, 2019 13:12 Failure
167130331-bug-(fix heroku build)
23f64e7 
 - add start script to package.json
[fixes 167130331 ];
@FrankChinedu FrankChinedu force-pushed the bug/167130331-fix-heroku-build branch from eea7a37 to 23f64e7 Compare July 8, 2019 13:14
@andela-johia
Copy link
Contributor

Everything looks good.

@andela-johia andela-johia merged commit 8a6a02c into staging Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FrankChinedu @andela-johia @vincentayorinde