166816218 get all users #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantastic-genius
requested review from
vincentayorinde,
caleb-42,
andela-johia,
FrankChinedu and
kevoese
fantastic-genius
force-pushed
the
feature/166816218-list-users-and-get-user-profile
branch
from
f84f104
to
49ada01
Compare
caleb-42
reviewed
Jul 16, 2019
|
|
||
| describe('Get all Users', () => { | ||
| before(async () => { | ||
| await createTestFakeUsers(); |
There was a problem hiding this comment.
Good job on using faker to generate data in your database to allow you test with. I think it would be good to clear the User table in your before block before running your test, since your test depends on the number of users it meets in the User table ---- line 391. This will avoid errors incase the User table had values before your test
There was a problem hiding this comment.
There is no need for that because the user whose token is been used to access the endpoint is created at the top level before hook declared first within the test file. Token can't be gotten from the fake users created.
fantastic-genius
force-pushed
the
feature/166816218-list-users-and-get-user-profile
branch
from
49ada01
to
b740bad
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
fantastic-genius
force-pushed
the
feature/166816218-list-users-and-get-user-profile
branch
2 times, most recently
from
240bbf7
to
b9d1b19
Compare
- Implement get all users feature - Add test for feature - Document feature [Delivers #166816218]
fantastic-genius
force-pushed
the
feature/166816218-list-users-and-get-user-profile
branch
from
b9d1b19
to
d0cde89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An authenticated user should be able to get all users
Type of change
Please select the relevant option
How Has This Been Tested?
please describe the test that you ran to verify your changes
Checklist:
Pivotal Tracker
#166816218