166816223 user can report article #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevoese
reviewed
Jul 17, 2019
routes/v1/reports.js
Outdated
| ); | ||
|
|
||
| router.get( | ||
| '/:id/article', |
There was a problem hiding this comment.
Good job on this PR. Following the convention from the other routes, it is better you use article slug in your params rather than the article id and also you don't need article at the end.
fantastic-genius
suggested changes
Jul 17, 2019
FrankChinedu
force-pushed
the
feature/166816223-user-can-report-an-article
branch
2 times, most recently
from
74f6ce6
to
399eae6
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
routes/v1/articles.js
Outdated
| @@ -3,6 +3,7 @@ import Validation from '../../validators/articles'; | |||
| import Article from '../../controllers/articles'; | |||
| import Middleware from '../../middlewares'; | |||
| import Comment from '../../controllers/comments'; | |||
| import report from '../../controllers/reports'; | |||
There was a problem hiding this comment.
'report' is defined but never used no-unused-vars
FrankChinedu
force-pushed
the
feature/166816223-user-can-report-an-article
branch
from
399eae6
to
37b3dc4
Compare
FrankChinedu
force-pushed
the
feature/166816223-user-can-report-an-article
branch
from
37b3dc4
to
35f1901
Compare
FrankChinedu
force-pushed
the
feature/166816223-user-can-report-an-article
branch
from
35f1901
to
eb02cb1
Compare
tests/routes/reports.spec.js
Outdated
|
|
||
| describe('ARTICLE FLAG', () => { | ||
| beforeEach(async () => { | ||
| mockDeleteImage = sinon.stub(utils, 'deleteImage') |
FrankChinedu
force-pushed
the
feature/166816223-user-can-report-an-article
branch
from
eb02cb1
to
41c332b
Compare
FrankChinedu
force-pushed
the
feature/166816223-user-can-report-an-article
branch
from
41c332b
to
c4418ee
Compare
- add report migration - add flagged column in article table - add Report Model - add report route - add report Controller - add tests [Delivers #166816223]
FrankChinedu
force-pushed
the
feature/166816223-user-can-report-an-article
branch
from
c4418ee
to
d9f8b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
report article gives user the ability to report article that violates terms and condition
Type of change
Please select the relevant option
How Has This Been Tested?
please describe the test that you ran to verify your changes
Checklist:
Pivotal Tracker
#166816223