Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

167942408 get related articles #63

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

vincentayorinde
Copy link
Contributor

Description

  • add get related articles route
  • add get related articles controller
  • add validation

Type of change

Please select the relevant option

  • Bug fix (non-breaking changes which fixes an issue)
  • New feature (non-breaking changes which adds functionality)
  • Breaking change (fix or feature that could cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Chore

How Has This Been Tested?

please describe the test that you ran to verify your changes

  • End to end
  • Integration
  • Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have linted my code prior to submission
  • I have made corresponding changes to the documentation
  • My changes generates no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Pivotal Tracker

#167942408

['createdAt', 'DESC']
]
}
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected newline before ')' function-paren-newline

error: 'Category not found'
});
}
const foundArticle = await db.Article.findAndCountAll(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected newline after '(' function-paren-newline

name: req.params.category
}
}
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected newline before ')' function-paren-newline


getRelatedArticles: async (req, res) => {
try {
const foundCategory = await db.Category.findOne(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected newline after '(' function-paren-newline

@vincentayorinde vincentayorinde temporarily deployed to demeter-ah-backend-stagi-pr-63 August 16, 2019 18:45 Inactive
@vincentayorinde vincentayorinde force-pushed the feature/167942408-get-related-articles branch from 66ed00f to 42ecfd6 Compare August 17, 2019 18:04
error: 'Category not found'
});
}
const foundArticles = await db.Article.findAndCountAll(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected newline after '(' function-paren-newline

 - add get related articles route
 - add get related articles controller
 - add validation
[Delivers #167942408]
@vincentayorinde vincentayorinde force-pushed the feature/167942408-get-related-articles branch from b8e7172 to 451e74f Compare August 20, 2019 09:34
@vincentayorinde vincentayorinde merged commit 2c35b6a into staging Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant