This repository has been archived by the owner on Jul 20, 2020. It is now read-only.
#170947570 manager re-confirm request #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izzett222
force-pushed
the
ft-reconfirm-request-170947570
branch
from
4d876c7
to
0c88d1a
Compare
izzett222
requested review from
Baraka-Mugisha,
bbaime98,
Ntare22 and
Mnickii
and removed request for
Baraka-Mugisha and
bbaime98
Baraka-Mugisha
suggested changes
Feb 26, 2020
izzett222
force-pushed
the
ft-reconfirm-request-170947570
branch
from
0c88d1a
to
536fe1a
Compare
Ntare22
previously approved these changes
Feb 26, 2020
Baraka-Mugisha
suggested changes
Feb 26, 2020
izzett222
force-pushed
the
ft-reconfirm-request-170947570
branch
from
536fe1a
to
23d56b9
Compare
Mnickii
reviewed
Feb 26, 2020
izzett222
force-pushed
the
ft-reconfirm-request-170947570
branch
from
23d56b9
to
c8f7232
Compare
izzett222
force-pushed
the
ft-reconfirm-request-170947570
branch
from
259b15e
to
db4387d
Compare
Ntare22
previously approved these changes
Feb 26, 2020
Baraka-Mugisha
previously approved these changes
Feb 26, 2020
izzett222
dismissed stale reviews from Baraka-Mugisha and Ntare22
via
5649290
izzett222
force-pushed
the
ft-reconfirm-request-170947570
branch
from
db4387d
to
5649290
Compare
Mnickii
reviewed
Feb 26, 2020
| @@ -107,7 +107,7 @@ export default class requestController { | |||
| passportName, | |||
| role | |||
| }], | |||
| status: 'Open' | |||
| status: 'open', | |||
There was a problem hiding this comment.
which case did we decide to go with?
There was a problem hiding this comment.
lower case is much better so that's what we are going with
Mnickii
reviewed
Feb 27, 2020
src/controllers/tripsController.js
Outdated
| @@ -49,7 +49,7 @@ export default class requestController { | |||
| passportName, | |||
| role | |||
| }], | |||
| status: 'Open' | |||
| status: 'Open', | |||
There was a problem hiding this comment.
Then this should change too
There was a problem hiding this comment.
let me change the code so that the data always inter the database as small letter even tho it wasn't entered as small letters
There was a problem hiding this comment.
I solved it, now when someone input data like a city, it will directly be converted to small letters
Mnickii
previously approved these changes
Feb 27, 2020
Ntare22
previously approved these changes
Feb 27, 2020
- add the reconfirm controller and route - test the feature - add the managerId and confirm attribute to the request table [Maintains #170947570]
izzett222
force-pushed
the
ft-reconfirm-request-170947570
branch
from
5649290
to
4ecfacd
Compare
bbaime98
approved these changes
Feb 27, 2020
Baraka-Mugisha
approved these changes
Feb 27, 2020
Ntare22
approved these changes
Feb 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add the re-confirm feature where a manager is able to confirm a decision (accepted or rejected) on a request
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#170947570
Screenshots (if appropriate)
Questions: