Skip to content
This repository has been archived by the owner on Jul 20, 2020. It is now read-only.

#171789422 user can view their requests #50

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

Baraka-Mugisha
Copy link
Collaborator

@Baraka-Mugisha Baraka-Mugisha commented Mar 16, 2020

What does this PR do?

  • add a feature whereby a user can view his requests

Description of Task to be completed?

  • added the feature's controller
  • tested the feature
  • documents the feature with swagger
  • internationalized response messages
  • modified notification links

How should this be manually tested?

  • clone this repo
  • run npm install to install all dependencies
  • run the server (npm run reset:dev)
  • make requests
  • make a get method to /api/v1/trips/{requestId}/view to view one specific request you made
  • or make a get method to /api/v1/trips/view to view all requests you made

Any background context you want to provide?

  • N/A

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Screen Shot 2020-03-19 at 13 58 42

Screen Shot 2020-03-19 at 13 59 21

Questions:

  • N/A

@Baraka-Mugisha Baraka-Mugisha added the in progress it is not yet done label Mar 16, 2020
@Baraka-Mugisha Baraka-Mugisha force-pushed the ft-view-request-171789422 branch 3 times, most recently from 71fa695 to 517c2e5 Compare March 17, 2020 07:49
@Baraka-Mugisha Baraka-Mugisha added ready for review and removed in progress it is not yet done labels Mar 17, 2020
src/controllers/tripsController.js Outdated Show resolved Hide resolved
@Baraka-Mugisha Baraka-Mugisha force-pushed the ft-view-request-171789422 branch 2 times, most recently from e4604c6 to cd093d5 Compare March 18, 2020 20:48
Copy link
Contributor

@Ntare22 Ntare22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the PR heading to match others?

@Baraka-Mugisha Baraka-Mugisha changed the title feat(viewRequests): user can view their requests #171789422, #171789422 user can view their requests Mar 19, 2020
@Baraka-Mugisha Baraka-Mugisha force-pushed the ft-view-request-171789422 branch 9 times, most recently from 75c6f81 to 17934a0 Compare March 19, 2020 12:34
bbaime98
bbaime98 previously approved these changes Mar 19, 2020
Ntare22
Ntare22 previously approved these changes Mar 19, 2020
src/controllers/tripsController.js Outdated Show resolved Hide resolved
src/swagger/trips.swagger.js Outdated Show resolved Hide resolved
@Baraka-Mugisha Baraka-Mugisha dismissed stale reviews from Ntare22 and bbaime98 via 8f8a81f March 20, 2020 09:13
@Baraka-Mugisha Baraka-Mugisha force-pushed the ft-view-request-171789422 branch 3 times, most recently from 9813354 to 4801733 Compare March 20, 2020 09:45
src/controllers/tripsController.js Outdated Show resolved Hide resolved
bbaime98
bbaime98 previously approved these changes Mar 20, 2020
Ntare22
Ntare22 previously approved these changes Mar 20, 2020
izzett222
izzett222 previously approved these changes Mar 23, 2020
added the feature's controller
tested the feature
documents the feature with swagger
internationalized response messages
[Finishes #171789422, #171789813]
@Ntare22 Ntare22 temporarily deployed to devrepublic-ft-view-req-ihezrd March 23, 2020 10:30 Inactive
@Baraka-Mugisha Baraka-Mugisha changed the title #171789422, #171789422 user can view their requests #171789422 user can view their requests Mar 23, 2020
@Ntare22 Ntare22 temporarily deployed to devrepublic-ft-view-req-wmvite March 23, 2020 11:04 Inactive
@jabichris jabichris merged commit 07cdf03 into develop Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants