This repository has been archived by the owner on Jul 20, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
#171789422 user can view their requests #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baraka-Mugisha
force-pushed
the
ft-view-request-171789422
branch
3 times, most recently
from
March 17, 2020 07:49
71fa695
to
517c2e5
Compare
Baraka-Mugisha
added
ready for review
and removed
in progress
it is not yet done
labels
Mar 17, 2020
izzett222
suggested changes
Mar 17, 2020
Baraka-Mugisha
force-pushed
the
ft-view-request-171789422
branch
2 times, most recently
from
March 18, 2020 20:48
e4604c6
to
cd093d5
Compare
Ntare22
suggested changes
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the PR heading to match others?
Baraka-Mugisha
changed the title
feat(viewRequests): user can view their requests
#171789422, #171789422 user can view their requests
Mar 19, 2020
Baraka-Mugisha
force-pushed
the
ft-view-request-171789422
branch
9 times, most recently
from
March 19, 2020 12:34
75c6f81
to
17934a0
Compare
bbaime98
previously approved these changes
Mar 19, 2020
Ntare22
previously approved these changes
Mar 19, 2020
izzett222
approved these changes
Mar 19, 2020
izzett222
suggested changes
Mar 19, 2020
Baraka-Mugisha
force-pushed
the
ft-view-request-171789422
branch
3 times, most recently
from
March 20, 2020 09:45
9813354
to
4801733
Compare
bbaime98
suggested changes
Mar 20, 2020
Baraka-Mugisha
force-pushed
the
ft-view-request-171789422
branch
from
March 20, 2020 10:49
4801733
to
a5e8c50
Compare
bbaime98
previously approved these changes
Mar 20, 2020
Ntare22
previously approved these changes
Mar 20, 2020
izzett222
previously approved these changes
Mar 23, 2020
added the feature's controller tested the feature documents the feature with swagger internationalized response messages [Finishes #171789422, #171789813]
Baraka-Mugisha
dismissed stale reviews from izzett222, Ntare22, and bbaime98
via
March 23, 2020 10:29
e6bc3dc
Baraka-Mugisha
force-pushed
the
ft-view-request-171789422
branch
from
March 23, 2020 10:29
a5e8c50
to
e6bc3dc
Compare
Baraka-Mugisha
changed the title
#171789422, #171789422 user can view their requests
#171789422 user can view their requests
Mar 23, 2020
Ntare22
approved these changes
Mar 23, 2020
bbaime98
approved these changes
Mar 23, 2020
izzett222
approved these changes
Mar 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
/api/v1/trips/{requestId}/view
to view one specific request you made/api/v1/trips/view
to view all requests you madeAny background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: