This repository has been archived by the owner on Jul 20, 2020. It is now read-only.
#170947580 add a get most traveled destinations feature #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
from
b30fb8e
to
3b35c02
Compare
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
4 times, most recently
from
ff4be4f
to
4523022
Compare
bbaime98
added
Review Required
bbaime98
requested review from
izzett222,
Baraka-Mugisha and
Ntare22
and removed request for
izzett222
bbaime98
changed the title
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
from
4523022
to
663a7cd
Compare
bbaime98
added
ready for review
and removed
Review Required
izzett222
suggested changes
Mar 19, 2020
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
7 times, most recently
from
cb78cef
to
b92a6ce
Compare
Baraka-Mugisha
suggested changes
Mar 24, 2020
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
2 times, most recently
from
292c91c
to
b934cdc
Compare
Ntare22
suggested changes
Mar 24, 2020
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
from
b934cdc
to
fe79d72
Compare
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
from
fe79d72
to
1c4c446
Compare
Ntare22
previously approved these changes
Mar 24, 2020
Baraka-Mugisha
previously approved these changes
Mar 24, 2020
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
from
1c4c446
to
25c1df4
Compare
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
from
25c1df4
to
652baa4
Compare
Baraka-Mugisha
approved these changes
Mar 24, 2020
Ntare22
previously approved these changes
Mar 24, 2020
izzett222
previously approved these changes
Mar 25, 2020
|
Good work @bbaime98, but I am wondering why are you limiting the user to just the top three traveled destinations? Just fix this so that this feature can be merged to develop. Happy coding! |
Baraka-Mugisha
suggested changes
Mar 25, 2020
- add most traveled destiantion route - add most traveled function - add the feature's tests and documentation [Finishes ##170947580]
bbaime98
force-pushed
the
ft-travelled-destinations-170947580
branch
from
652baa4
to
efab6ad
Compare
Baraka-Mugisha
approved these changes
Mar 25, 2020
Ntare22
approved these changes
Mar 25, 2020
izzett222
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
/api/v1/auth/register/api/v1/auth/login/api/v1/trips/most-travelledAny background context you want to provide?
What are the relevant pivotal tracker stories?
#170947580
Screenshots (if appropriate)
Questions: