Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#160484109 Add admin role #36

Merged
merged 1 commit into from
Sep 18, 2018
Merged

#160484109 Add admin role #36

merged 1 commit into from
Sep 18, 2018

Conversation

OKiMaureen
Copy link
Collaborator

What does this PR do?

Add admin role to model

Description of Task to be completed?

  • add admni role to model
  • add seeded admin to model

How should this be manually tested?

Run these commands;

  • npm install
  • npm test

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

https://www.pivotaltracker.com/story/show/160484109

@OKiMaureen OKiMaureen changed the title 160484109 Add admin role #160484109 Add admin role Sep 14, 2018
@coveralls
Copy link

coveralls commented Sep 14, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 815

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.5%
Totals Coverage Status
Change from base Build 751: 0.0%
Covered Lines: 737
Relevant Lines: 781
💛 - Coveralls

@OKiMaureen OKiMaureen requested review from veeqtor, klevamane and Lumexralph and removed request for veeqtor September 14, 2018 05:13
ft(mode): Add admin role
fb6f921 
- add admnin role to model
- add seeded admin to model

[Delivers #160484109]
anuonifade
anuonifade approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@anuonifade anuonifade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anuonifade anuonifade merged commit 531f8d8 into develop Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuonifade anuonifade anuonifade approved these changes

@klevamane klevamane Awaiting requested review from klevamane

@Lumexralph Lumexralph Awaiting requested review from Lumexralph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OKiMaureen @coveralls @anuonifade @klevamane