Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#168371026 Fix staging deployment #38

Merged
merged 17 commits into from
Sep 10, 2019
Merged

#168371026 Fix staging deployment #38

merged 17 commits into from
Sep 10, 2019

Conversation

OlawaleJoseph
Copy link
Collaborator

@OlawaleJoseph OlawaleJoseph commented Sep 9, 2019

What does this PR do?

Adds Clean script to package.json file
Adds build script to package.json file
Adds heroku-postbuild script to package.json file

Description of Task to be completed?

Make changes to the app to ensure it runs in the staging environment

How should this be manually tested?

Open postman, make a get request to https://firestar-backend-staging-pr-38.herokuapp.com/api/v1/users/email/verify with an email in the request body. An appropriate message will be received

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#168371026

Screenshots (if appropriate)

Screenshot (56)
Screenshot (57)
Screenshot (58)
Screenshot (59)

Questions:

N/A

@OlawaleJoseph OlawaleJoseph added the work in progress This PR is still a work in progress. do not merge! label Sep 9, 2019
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 10:44 Inactive
@OlawaleJoseph OlawaleJoseph reopened this Sep 9, 2019
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 11:31 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 12:31 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 12:59 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 13:34 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 13:46 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 13:55 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 14:14 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 14:15 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 14:19 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 14:28 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 9, 2019 15:15 Inactive
@OlawaleJoseph OlawaleJoseph added peer Review This PR is up for team members reviews and removed work in progress This PR is still a work in progress. do not merge! labels Sep 9, 2019
Copy link
Collaborator

@conquext conquext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach the screenshot of the successful build and migrations in the PR.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@rovilay rovilay temporarily deployed to firestar-backend-staging-pr-38 September 10, 2019 01:34 Inactive
Copy link
Collaborator

@dewaleolaoye dewaleolaoye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POST request on https://firestar-backend-staging-pr-38.herokuapp.com/api/v1/auth/login throws
404 error

@conquext
Copy link
Collaborator

POST request on https://firestar-backend-staging-pr-38.herokuapp.com/api/v1/auth/login throws
404 error

The ticket for that route is still in review. Have you tried any other route whose ticket is merged to stage?

@dewaleolaoye
Copy link
Collaborator

POST request on https://firestar-backend-staging-pr-38.herokuapp.com/api/v1/auth/login throws
404 error

The ticket for that route is still in review. Have you tried any other route whose ticket is merged to stage?

Okay, I use what is on the PR how to manually test

@OlawaleJoseph OlawaleJoseph added ready for merge This PR is ready for TTL review and merging and removed peer Review This PR is up for team members reviews labels Sep 10, 2019
@rovilay rovilay temporarily deployed to firestar-backend-staging September 10, 2019 09:39 Inactive
@rovilay rovilay temporarily deployed to firestar-backend-staging September 10, 2019 09:47 Inactive
@rovilay rovilay merged commit dcc23b9 into stage Sep 10, 2019
@OlawaleJoseph OlawaleJoseph temporarily deployed to firestar-backend-staging September 11, 2019 15:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR is ready for TTL review and merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants